Add max line length Ruff rule #792
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This started as a PR for adding the entire E Ruff rule, but there were so many changes that I decided to split the max line length rule into its own PR. See #793, which adds the rest of the E rules.
Set it to 88, which is the default value of both Ruff (see https://docs.astral.sh/ruff/settings/#line-length) and Black (see https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length). It also really helps with viewing files side-by-side in an IDE, and viewing files on GitHub.
Also:
pre-committo 4.5.1urlencode()with passing the query parameters as thedataargument toClient.get()Review guidance
Checklist
(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)
makemigrations,makemessagesandcompilemessages