Skip to content

Conversation

@ddabble
Copy link
Member

@ddabble ddabble commented Feb 11, 2026

Proposed changes

This started as a PR for adding the entire E Ruff rule, but there were so many changes that I decided to split the max line length rule into its own PR. See #793, which adds the rest of the E rules.

Set it to 88, which is the default value of both Ruff (see https://docs.astral.sh/ruff/settings/#line-length) and Black (see https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length). It also really helps with viewing files side-by-side in an IDE, and viewing files on GitHub.

Also:

  • Upgraded pre-commit to 4.5.1
  • [forms/machine.py] Made a string translated that was missing it.
  • [test_api_reservation_views.py] Replaced urlencode() with passing the query parameters as the data argument to Client.get()

Review guidance

Checklist

(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)

  • I've run makemigrations, makemessages and compilemessages
  • I've written tests that fail without these changes (if relevant/possible)
  • I've manually tested the website UI with different device layouts
    • Most common is to test with typical screen sizes for mobile (320-425 px), tablet (768 px) and desktop (1024+ px), which can easily be done with your browser's dev tools
  • I've manually tested with different users locally
    • This can be e.g. anonymous users (i.e. not being logged in), "normal" non-member users, members of different committees, and superusers
  • I've made sure that my code conforms to the code style guides
    • It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you use it as a reference guide / checklist while taking a second look at your code before opening a pull request
  • I've attempted to minimize the number of common code smells
    • See the comment for the previous checkbox
  • I've added documentation
    • E.g. comments, docstrings, or in the README
  • I've added my changes to the "Unreleased" section of the changelog, together with a link to this PR
    • Mainly the changes that are of particular interest to users and/or developers, if any
  • I've added a "Deployment notes" section above and labelled the PR with has-deployment-notes
    • ...if anything out of the ordinary should be done when deploying these changes to the server (e.g. adding/removing an environment variable, manually creating/changing some objects, running a management command, etc.)
  • I've structured my commits reasonably

Set it to 88, which is the default value of both Ruff (see
https://docs.astral.sh/ruff/settings/#line-length) and Black (see
https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length
). It also really helps with viewing files side-by-side in an IDE, and
viewing files on GitHub.

Also:
* Upgraded `pre-commit` to 4.5.1
* [forms/machine.py] Made a string translated that was missing it.
* [test_api_reservation_views.py] Replaced `urlencode()` with passing
  the query parameters as the `data` argument to `Client.get()`
@ddabble ddabble requested a review from TheStrgamer February 11, 2026 09:21
@make-bot make-bot bot added this to web Feb 11, 2026
@make-bot make-bot bot moved this to Ready for Review in web Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.01%. Comparing base (76d1a07) to head (b84426d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #792   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files         153      153           
  Lines        6224     6225    +1     
=======================================
+ Hits         5478     5479    +1     
  Misses        746      746           
Files with missing lines Coverage Δ
src/announcements/models.py 93.93% <ø> (ø)
src/card/utils.py 46.15% <ø> (ø)
src/card/views.py 56.00% <ø> (ø)
src/checkin/local_scanner.py 0.00% <ø> (ø)
src/checkin/urls.py 100.00% <ø> (ø)
src/checkin/views.py 40.16% <100.00%> (ø)
src/contentbox/forms.py 100.00% <ø> (ø)
src/contentbox/models.py 100.00% <ø> (ø)
src/contentbox/views.py 100.00% <ø> (ø)
src/dataporten/ldap_utils.py 69.04% <ø> (ø)
... and 65 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddabble ddabble mentioned this pull request Feb 11, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

1 participant