feat: allow GetCoinbaseAddress support in ICS consumer chain #19
Conversation
fix interface fix lint
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
x/vm/keeper/block_proposer.go
Outdated
| func (k Keeper) GetCoinbaseAddress(ctx sdk.Context, proposerAddress sdk.ConsAddress) (common.Address, error) { | ||
| validator, err := k.stakingKeeper.GetValidatorByConsAddr(ctx, GetProposerAddress(ctx, proposerAddress)) | ||
| if err != nil { | ||
| // Consumer chains have no bonded tokens. |
There was a problem hiding this comment.
should we just use zero address if any error happens.
There was a problem hiding this comment.
I thought we could use provider's proposer as block.coinbase for consumer, maybe it's against the fact there's no local validator.
3 participants
Description
backport cosmos#917
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch