Selections from R feature request #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to select row/column labels when creating an NG-CHM that will be visible in the NG-CHM viewer. Usage documentaiton and examples are in the panel_configuration constructor documentation.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying panel selections by row/column labels and converts them to indices for the NG-CHM viewer.
- Introduces
selectionsparameter throughoutpanel_configurationclasses, methods, and documentation. - Implements label-to-index conversion via
convertPanelSelectionsFromLabelToIndex, plus file‐reading helpers. - Adds tests covering hclust, dendrogram, and label-based selection conversion.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-selections.R | New tests for converting label-based selections to indices |
| man/panel_configuration.Rd | Updated constructor docs to include selections and usage examples |
| man/panel_configuration-class.Rd | Added selections slot documentation |
| man/default_panel_configuration.Rd | Removed outdated default config docs |
| R/panelFunctions.R | Made default_panel_configuration internal and added default selections |
| R/panelClasses.R | Added selections slot and constructor argument to class |
| R/allMethods.R | Added convertPanelSelectionsFromLabelToIndex and hooked into chmMake |
| R/ngchmshaidy.R | Added getLabelsFromFile and getDendrogramOrderFromFile helpers |
| NAMESPACE | Removed export of default_panel_configuration |
Comments suppressed due to low confidence (1)
man/panel_configuration.Rd:45
- [nitpick] This sentence is duplicated; remove one occurrence to avoid redundancy in the documentation.
Each element must be a detailMap, summaryMap, or pluginPane object.
bmbroom
approved these changes
Jul 16, 2025
Member
bmbroom
left a comment
bmbroom
left a comment
There was a problem hiding this comment.
Adds an important capability to the NGCHM R package as discussed in weekly NG-CHM meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the "Selections from R" feature request.
This allows users to select row/column labels when creating an NG-CHM that will be visible in the NG-CHM viewer.
Usage documentation and examples are in the panel_configuration constructor documentation.
All tests pass, and
R CMD CHECK --as-cranyields no issues.