update to use Rx

[clautour]

No description provided.

[MattDavies]

Hey mate,

So this is cool, nice work. It does feels like we're adding a fair bit of complexity (what was there was intentionally very simple) but if that's warranted that's okay. Does the introduction of RX actually solve the problem with the service generating lots of packages? Did you end up suspecting the issue was the timer not being cancelled properly?

There's a few other things going on here - do you think it's worth splitting out the templating and config transform stuff (not really sure what you're trying to do there) so we can work together on just the RX change?

Thanks

[clautour]

Does the introduction of RX actually solve the problem with the service generating lots of packages? Did you end up suspecting the issue was the timer not being cancelled properly?

Correct, only a single packages is pushed now. I didn't dig to deeply into the the timer implementation, having written such things in the past they can be quite tricky to debug. Overall I find Rx a much simpler implementation.

NuGetDirSync.exe    Information 0   Changes Detected - Waiting for more 2015-07-23 00:24:13Z
NuGetDirSync.exe    Information 0   Changes Detected - Waiting for more 2015-07-23 00:24:21Z
NuGetDirSync.exe    Information 0   Begining packaging process  2015-07-23 00:24:51Z
NuGetDirSync.exe    Information 0   Cloning directory to tmp\0.0.2568   2015-07-23 00:24:51Z
NuGetDirSync.exe    Information 0   Building Package - 0.0.2568 2015-07-23 00:24:53Z
NuGetDirSync.exe    Information 0   Attempting to build package from 'RWWA.BetLab.CmsContent.nuspec'.
Successfully created package 'tmp\0.0.2568\RWWA.BetLab.CmsContent.0.0.2568.nupkg'.
    2015-07-23 00:24:56Z
NuGetDirSync.exe    Information 0   Publising package - tmp\0.0.2568\RWWA.BetLab.CmsContent.0.0.2568.nupkg  2015-07-23 00:24:56Z
NuGetDirSync.exe    Information 0   Pushing RWWA.BetLab.CmsContent 0.0.2568 to 'http://10.22.0.6/nuget/packages'...
Your package was pushed.
    2015-07-23 00:25:48Z
NuGetDirSync.exe    Information 0   Cleaning up - deleting tmp\0.0.2568 2015-07-23 00:25:48Z

I added the tempting because of this line
File.WriteAllText(_packageNuSpec, string.Format(File.ReadAllText(_packageNuSpec), _packageName));
. TBH I'm not sure it did anything as I didn't find{0} in place of the name in the .nuspec file. I would rather take advantage of strong typing that the .tt template gives.

Config transform stuff was just to make it easier to debug with decent defaults - I'm not fussed about it staying or going. I did miss the plugin adding a bunch of files which aren't needed though, I'll get rid of them regardless.