Skip to content

Add option for plot; Increase flexibility of input args; Add comments…#3

Open
mharms wants to merge 2 commits intoMRIMotionCorrection:masterfrom
mharms:MPHchanges
Open

Add option for plot; Increase flexibility of input args; Add comments…#3
mharms wants to merge 2 commits intoMRIMotionCorrection:masterfrom
mharms:MPHchanges

Conversation

@mharms
Copy link

@mharms mharms commented Nov 22, 2017

… to script

Copy link
Contributor

@mdtisdall mdtisdall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. One small request I'd make is that the import of the pyplot lib be moved into the simplePlot function. This allows the code to run on environments where pyplot isn't installed. Perhaps getting pyplot installed and running is trivial, but I'm not a very strong python user and I've had some issues getting it configured on headless systems. I figure this way we can make the script useable in its basic, text-only form with fewer dependencies. Is that okay with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants