Add option for plot; Increase flexibility of input args; Add comments…#3
Open
mharms wants to merge 2 commits intoMRIMotionCorrection:masterfrom
Open
Add option for plot; Increase flexibility of input args; Add comments…#3mharms wants to merge 2 commits intoMRIMotionCorrection:masterfrom
mharms wants to merge 2 commits intoMRIMotionCorrection:masterfrom
Conversation
mdtisdall
requested changes
Dec 23, 2017
Contributor
mdtisdall
left a comment
There was a problem hiding this comment.
This is great. One small request I'd make is that the import of the pyplot lib be moved into the simplePlot function. This allows the code to run on environments where pyplot isn't installed. Perhaps getting pyplot installed and running is trivial, but I'm not a very strong python user and I've had some issues getting it configured on headless systems. I figure this way we can make the script useable in its basic, text-only form with fewer dependencies. Is that okay with you?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to script