Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

fix sidebar English language#286

Open
noams24 wants to merge 5 commits intoMaakaf:mainfrom
noams24:fix-drawer
Open

fix sidebar English language#286
noams24 wants to merge 5 commits intoMaakaf:mainfrom
noams24:fix-drawer

Conversation

@noams24
Copy link
Contributor

@noams24 noams24 commented May 19, 2024

Issue #271

@vercel
Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maakaf-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 1:29pm

const localActive = useTypedLocale();
const { theme } = useTheme();
const t = useTranslations('Components.sideBar');
const navigationItems: NavigationItems[] = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this scope this array will be re declared on every render

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but how can I use the "useTranslations" hook outside this scope?

`fixed inset-y-0 z-50 bg-lightBg dark:bg-darkBg border-l
border-l-blue-400 w-[75%] shadow-lg transform transition-transform
ease-in-out duration-300`,
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not use dir here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't worked so well using dir

Copy link
Contributor

@Avi-E-Koenig Avi-E-Koenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address review.

@Avi-E-Koenig
Copy link
Contributor

@noams24 please resolve conflicts

@Avi-E-Koenig
Copy link
Contributor

@noams24 please update

@noams24
Copy link
Contributor Author

noams24 commented Jun 1, 2024

I still couldn't figured how to fix this error:
image

Maybe @Tamir198 knows how solve it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants