Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

fix SideBar mobile translate #289

Open
roi1410 wants to merge 3 commits intoMaakaf:mainfrom
roi1410:fixMobileTranslateBTN
Open

fix SideBar mobile translate #289
roi1410 wants to merge 3 commits intoMaakaf:mainfrom
roi1410:fixMobileTranslateBTN

Conversation

@roi1410
Copy link
Contributor

@roi1410 roi1410 commented May 22, 2024

I am going to be honest i think i fix your tests but with chat gpt I just told it what error happened and in response it told me to check shit . on pre commit fille it should be sh fille and with the following code .

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npm run precommit

I don't know if it ran the tests that you wish but if we are here and it work

**original prepes **
add translate to sideBar and translateBTN

@vercel
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maakaf-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 10:05am

@roi1410 roi1410 changed the title delete husky fix SideBar mobile translate fix SideBar mobile translate May 22, 2024
@Avi-E-Koenig
Copy link
Contributor

I am going to be honest i think i fix your tests but with chat gpt I just told it what error happened and in response it told me to check shit . on pre commit fille it should be sh fille and with the following code .

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npm run precommit

I don't know if it ran the tests that you wish but if we are here and it work

**original prepes ** add translate to sideBar and translateBTN

When I made said change I was unaware of the OS diffs as I mainly work on linux.
If that fixes the issues then yes this approach is best...however this is not part of the commits here...where was this applied?

@roi1410
Copy link
Contributor Author

roi1410 commented May 25, 2024

When I made said change I was unaware of the OS diffs as I mainly work on linux. If that fixes the issues then yes this approach is best...however this is not part of the commits here...where was this applied?

it was applied in .husky/pre-commit changed to .sh and code changed and the same at ... pre-push with the push command
image
I think there you can see it here
#290

@roi1410
Copy link
Contributor Author

roi1410 commented May 30, 2024

more changes are needed?

@Avi-E-Koenig
Copy link
Contributor

@roi1410 please resolve conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants