added Version 1.21.4 - 1.21.8

[ShadowDara]

...

[MacaylaMarvelous81]

Thanks for the pull request! I’ll look into it in a few moments, but with a cursory view it looks like you removed an override without any replacement. Can you explain your reasoning?

[ShadowDara]

Oh, sorry, my bad, i opened this too early, some commits are missing

[MacaylaMarvelous81]

I've just done a basic test on release 2.0.0 with Minecraft 1.21.8, and it seems to work fine. Are you encountering any issues to warrant the upgrade?

[ShadowDara]

On my PC the @Override in Line 27 CreateWorldScreenMixin.java leads to a crash in 1.21.4

Snippet

    @Overwrite
    @Nullable
    private Path getDataPackTempDir() {
        this.dataPackTempDir = DatapackInstallerClient.MAIN_PATH;
        return this.dataPackTempDir;
    }

when removing the @override, the function is not used anymore and MC is using again the temporary created datapack folder in the world creation menu

Later in playing it will use the DP folder from the mod

OH

This is a lot more complicated then thought before, the new function for getDataPackTempDir() is in the construktor of CreateWorldScreen

I am working on it at the moment

[ShadowDara]

So, I think, I fixed it, the version works and its using the Custom Folder DatapackInstaller\run\client\datapacks, not in temp LocalAppData

[MacaylaMarvelous81]

Weird. I can't seem to reproduce your issue with 1.21.4, either. Which jar from the release are you using?

[ShadowDara]

I used the source code and compiled it myself in Intellij Idea, this is probably the reason. I dont think this would make a difference but i am using Temurium 21 JDK

[MacaylaMarvelous81]

By "compiled it myself in Intellij Idea," do you mean that you compiled the mod and then used the resulting artifact in game, or you ran the game from your IDE directly?