Skip to content

feat: do not show build log on node select #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchalamet merged 1 commit into from
Jan 17, 2026
Merged

feat: do not show build log on node select #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 2 additions & 33 deletions src/Terrabuild.UI/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,6 +788,8 @@ const App = () => {
setSelectedProject(project);
setSelectedNodeId(project.id);
setSelectedTargetKey(null);
setShowTerminal(false);
setBuildEndedAt(null);
const freshResults: Record<string, TargetSummary> = {};
await Promise.all(
project.targets.map(async (node) => {
Expand All @@ -808,39 +810,6 @@ const App = () => {
if (Object.keys(freshResults).length > 0) {
setNodeResults((prev) => ({ ...prev, ...freshResults }));
}
if (project.targets.length === 0) {
return;
}
const resultsLookup = { ...nodeResults, ...freshResults };
const newestTarget = project.targets.reduce((newest, candidate) => {
if (!newest) {
return candidate;
}
const newestKey =
`${newest.projectHash}/${newest.target}/${newest.targetHash}`;
const candidateKey =
`${candidate.projectHash}/${candidate.target}/${candidate.targetHash}`;
const newestSummary = resultsLookup[newestKey];
const candidateSummary = resultsLookup[candidateKey];
const newestTime = newestSummary
? Date.parse(newestSummary.startedAt || newestSummary.endedAt)
: Number.NEGATIVE_INFINITY;
const candidateTime = candidateSummary
? Date.parse(candidateSummary.startedAt || candidateSummary.endedAt)
: Number.NEGATIVE_INFINITY;
if (candidateTime === newestTime) {
return candidate.target.localeCompare(newest.target) > 0
? candidate
: newest;
}
return candidateTime > newestTime ? candidate : newest;
}, null as GraphNode | null);
if (!newestTarget) {
return;
}
const newestKey =
`${newestTarget.projectHash}/${newestTarget.target}/${newestTarget.targetHash}`;
await showTargetLog(newestKey, newestTarget);
};

const loadTargetLog = async (key: string, target: GraphNode) => {
Expand Down