Allowing message field to be null to match SLF4J behavior#12
Open
quidryan wants to merge 1 commit intoMahoney:masterfrom
Open
Allowing message field to be null to match SLF4J behavior#12quidryan wants to merge 1 commit intoMahoney:masterfrom
quidryan wants to merge 1 commit intoMahoney:masterfrom
Conversation
Owner
|
Hi, Thanks for this. I was trying to follow a philosophy of never storing or exposing null, so always using Optional where a value could be absent, so this fix would break that pattern. On the other hand this fix is backwards compatible, whereas changing getMessage() on LoggingEvent to return Optional would be a breaking change (though hopefully not a terribly arduous one if people are comparing events using the static helper constructors). I'll think about what to do; possibly apply this change as a bug fix release to the 1.2 branch and make the breaking change in a 2.0 release. |
|
+1 |
|
Any hope of getting this merged and getting a new release of |
|
Please check out https://github.com/valfirst/slf4j-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(not really documented in Slf4j)
Quick stab at fixing #11. Comments welcome.