Morse decoder with Elixir#3
Conversation
|
Your 👀 are appreciated here too @JasonSoares (my first code attempt with Elixir). |
|
Awesome! I get to learn elixir as well! Thanks! I'll review it later! 👍 |
AlphaGit
left a comment
AlphaGit
left a comment
There was a problem hiding this comment.
I think it's a very good attempt! Out of curiosity, how long did it take you to get this done?
|
|
||
| Documentation can be generated with [ExDoc](https://github.com/elixir-lang/ex_doc) | ||
| and published on [HexDocs](https://hexdocs.pm). Once published, the docs can | ||
| be found at [https://hexdocs.pm/morse](https://hexdocs.pm/morse). |
There was a problem hiding this comment.
Aw man, you DID publish them: https://hexdocs.pm/morse/Morse.html#content
That's so cool!
There was a problem hiding this comment.
Lol. That wasn't me 😄
But I definitively should clean up these docs. I'm probably to move this code to a personal repo and improve it.
|
Thanks @DanielAltamirano and @AlphaGit. It was really interesting, and I liked the challenge.
Well I didn't measure it, because it is a new language for me. But I think I was between 3 and 4 hours which involves:
|
|
@matiasbeckerle Gotcha -- thanks! |
|
Hey folks... should I close this PR? I'm cleaning up all my open PRs and I've found this one. @DanielAltamirano @AlphaGit |
|
@matiasbeckerle I'm fine with that! |
|
Hi @matiasbeckerle, I did not have time to review this yet (and neither fix mine one), but I think that you should merge it, it will be a shame if you close it without merge. |
|
Thank you @AlphaGit @andresmoschini. I will wait for @DanielAltamirano's blessing before moving forward. |
|
We need your bless @mbeckerle, do not wait for him. ;)
|
|
Note: @andresmoschini - mbeckerle (me) is not same as @matiasbeckerle. You wanted to comment for him. |
|
Ooops, sorry Mike, and thanks for your nice and polite message to make me know about my error. |
|
Ok based on @andresmoschini and @AlphaGit comments I will merge this one. We can revert it if needed. |
5 participants
Probably not the best approach, but it works. I did a hack which I will try to improve some day. Added the whole project so anyone can install Elixir and run the project easily. Anyways, the important files:
lib/morse.ex.test/morse_test.exsHere is the sausage: https://github.com/MakingSense/coding-dojo/pull/3/files#diff-034ed42181ecd30c24e51db7f0c06898R18
The hack explanation:
I wanted to solve the whole thing using the pipe operator
|>. The problem I had was that after splitting by words I also need to split by letters. But at some point there is a return that it was sending me the words and not the letters. This is of course the lack of knowledge over the language (this is my first attempt to code something in this language). The hacks consists on translate the words separator (triple space) as another morse symbol.