feat(slack): advertise when others are creating an incident#115
Open
jennafauconnier wants to merge 4 commits intomainfrom
Open
feat(slack): advertise when others are creating an incident#115jennafauconnier wants to merge 4 commits intomainfrom
jennafauconnier wants to merge 4 commits intomainfrom
Conversation
…nd a message to signal that's someone is creating an incident
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 62.83% 62.75% -0.08%
==========================================
Files 215 215
Lines 9587 9613 +26
Branches 1289 1289
==========================================
+ Hits 6024 6033 +9
- Misses 3354 3371 +17
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GabDug
reviewed
Oct 29, 2024
| @receiver(signal=create_incident_conversation) | ||
| def create_incident_slack_conversation( | ||
| incident: Incident, | ||
| source_channel: IncidentChannel, |
Contributor
There was a problem hiding this comment.
In trigger_incident_workflow, it's Any, so we need to check that it's an IncidentChannel, and probably accept None by default.
Collaborator
|
/rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Notifications for Incident Opening and Creation Links in Slack
Description
This PR introduces two new message classes for handling notifications related to incident management in the Slack application. The first class provides a warning when a user is in the process of opening an incident, while the second class informs users when a new incident has been created.
Changes Made
✅ Created SlackMessageIncidentOpeningWarning to notify users when an incident is being opened.
✅ Created SlackMessageIncidentCreationRedirection to inform users of a new incident creation.
✅ Updated IDs for both classes to ensure they are distinct and descriptive.
Motivation and Context
These changes are important to improve user experience by preventing multiple incident creations and guiding users to newly created incidents. By providing timely notifications, we can enhance communication and efficiency within the team.
How to Test
Checklist