Skip to content

Conversation

@cidopenup0
Copy link

📌 Description

This PR fixes the notification service failure in the Kubernetes deployment by correcting configuration mismatches and missing secrets.

What does this PR do?

  • Fixes a database name mismatch between MySQL and the notification service
  • Adds the missing database username to Kubernetes secrets
  • Corrects the notification service URL to use internal Kubernetes service discovery

Why is this change needed?

The notification service was unable to connect to its database and receive events due to incorrect database configuration, missing authentication credentials, and improper inter-service communication. These issues prevented notifications from being stored and delivered in the Kubernetes environment.


🔗 Related Issue

Fixes #52


🛠️ Type of Change

Please mark the relevant option:

  • Documentation update
  • Bug fix
  • New feature
  • Refactor
  • Configuration / DevOps change
  • Other (please explain)

🧪 How Was This Tested?

Verification steps:

  • Confirmed all pods are running in the microforge-dev-ns namespace

  • Checked notification service logs for database connection errors

  • Verified internal service discovery using Kubernetes DNS

  • Tested /api/notifications endpoint using an in-cluster curl pod

  • Confirmed notifications are triggered on user login/registration events

  • Docker Compose runs successfully

  • Frontend loads correctly

  • Service builds without errors

  • Documentation renders correctly

  • Manual testing


📸 Screenshots


image
image
image
Image

✅ Checklist

Please confirm the following:

  • My code follows the project structure
  • I tested my changes locally
  • I linked the relevant issue
  • I kept this PR focused and minimal
  • I am open to feedback and changes

📝 Additional Notes

Nothing

@github-actions
Copy link

Hi @cidopenup0 Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

@Manoj-14 Manoj-14 self-requested a review January 12, 2026 14:43
DB_NAME: empdir
JWT_EXPIRATION_MS: "86400000"
NOTIFICATION_SERVICE_URL: http://api.microforge.manojm.site
NOTIFICATION_SERVICE_URL: http://notification-service:8083
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright iam working it

Copy link
Author

@cidopenup0 cidopenup0 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Manoj-14 i have tried to add ip of ingress-nginx-controller cluster IP but this is considered as bad practice so i consider the old http://notification-service:8083 way as better option and using service names is standard practice for service to service communication

    spec:
+      hostAliases:
+      - ip: "10.102.83.6"  # ingress-nginx-controller ClusterIP
+        hostnames:
+        - "api.microforge.manojm.site"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants