Feat/mm implementation #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the v13 upgrade to the Terra Classic blockchain application, implementing significant changes to tax distribution and market functionality. The upgrade adds a new tax redirect mechanism that directs a portion of collected taxes to a market accumulator module, while also integrating oracle-based USD pricing for enhanced market operations.
- Implements v13 upgrade with restricted swap denomination support to only
uusd - Introduces tax redirect rate parameter allowing configurable percentage of taxes to flow to market accumulator
- Adds USD pricing functionality to oracle module using meta-denom for USTC/USD conversion
- Implements market epoch processing with burn/refill cycles for pool management
Reviewed Changes
Copilot reviewed 59 out of 61 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
app/app.go |
Integrates v13 upgrade handler and updates transaction service registration |
app/modules.go |
Updates module permissions and replaces standard modules with custom implementations |
app/upgrades/v13/ |
Defines v13 upgrade constants and logic restricting swap denoms to uusd |
x/treasury/types/ |
Adds TaxRedirectRate parameter for market redirect functionality |
x/tax/keeper/ |
Implements tax splitting logic with market redirect support and event emission |
x/oracle/types/ |
Adds USD pricing queries and meta-denom support for USTC/USD rates |
x/market/types/ |
Adds epoch processing parameters and accumulator module support |
custom/auth/ |
Updates transaction service and fee test coverage for new tax logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| func validateTaxRedirectRate(i interface{}) error { | ||
| v, ok := i.(sdk.Dec) | ||
| if !ok { | ||
| return fmt.Errorf("invalid paramater type: %T", i) |
There was a problem hiding this comment.
The word "paramater" is misspelled. It should be "parameter".
Suggested change
| return fmt.Errorf("invalid paramater type: %T", i) | |
| return fmt.Errorf("invalid parameter type: %T", i) |
| for ; iter.Valid(); iter.Next() { | ||
| denom := string(iter.Key()[len(types.ExchangeRateKey):]) | ||
| // Skip duplicate entry if denom is uluna (already pushed) | ||
| if denom == core.MicroLunaDenom || denom == types.MetaUSDDenom || len(denom) == 0 || denom[0] != 'u' { |
There was a problem hiding this comment.
The hardcoded check for denom[0] != 'u' is fragile and could fail for valid denoms. Consider using a more robust validation method or making this configurable.
Suggested change
| if denom == core.MicroLunaDenom || denom == types.MetaUSDDenom || len(denom) == 0 || denom[0] != 'u' { | |
| if denom == core.MicroLunaDenom || denom == types.MetaUSDDenom || len(denom) == 0 || sdk.ValidateDenom(denom) != nil { |
| } | ||
| } | ||
| // Deduct redirected portion from taxes before any other splits | ||
| taxes = taxes.Sub(marketSplitCoins...) |
There was a problem hiding this comment.
The Sub operation could panic if marketSplitCoins contains denoms not present in taxes or if amounts are insufficient. Consider adding validation to ensure safe subtraction.
…ssic-terra#588) Co-authored-by: Tuan Tran <tropicaldog17@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Mergify <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Khanh Hoa <hoa@notional.ventures> Co-authored-by: Kien Trinh <51135161+kien6034@users.noreply.github.com> Co-authored-by: StrathCole <strathcole@gmail.com> Co-authored-by: DevOrbitlabs <hoank@protonmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
- e2e testing adjustments - bump to newer wasmd 0.54 - fix tests
- fix upgrade test - change legacy height
update upgrade height of multi test
- update go version to 1.24.7
fix ibc hooks ic test change to cosmos interchaintest v10
Strath/next gen plus
* refactor app * update lint * fix lint * fix lint * fix lint * update cl
* longer timeout * fix test * lint * adjust * bet
- twap and oracle vote age checks
Co-authored-by: Tuan Tran <tropicaldog17@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: DevOrbitlabs <hoa@notional.ventures>
# Conflicts: # go.mod # go.sum # scripts/run-node-legacy.sh # tests/interchaintest/go.mod # tests/interchaintest/go.sum # wasmbinding/query_plugin.go # wasmbinding/wasm.go
- fix lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes (Copilot)
This pull request introduces the v13 upgrade to the Terra Classic blockchain application and refines the handling of tax distribution logic, especially regarding market redirection. It also updates several module integrations and improves test coverage for new tax behaviors. The most important changes are grouped below:
Upgrade Integration
uusd. (app/app.go,app/upgrades/v13/constants.go,app/upgrades/v13/upgrades.go) [1] [2] [3] [4]Tax Distribution and Market Redirect Logic
custom/auth/ante/fee_test.go) [1] [2] [3] [4] [5] [6] [7] [8] [9]Module and Keeper Integration
app/modules.go) [1] [2]app/modules.go) [1] [2] [3]API and Service Changes
TaxExemptionKeeper, ensuring exemption logic is properly available in transaction handling. (app/app.go,custom/auth/tx/service.go) [1] [2] [3]Codebase Cleanup
custom/auth/ante/fee_test.go) [1] [2]These updates ensure the application supports the new v13 upgrade, correctly handles tax and fee distribution (including market redirects), and maintains robust test coverage for these changes.