Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/marketdata/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ class MarketDataSettings(BaseSettings, UniversalParamsSettings):
marketdata_api_version: str = "v1"
marketdata_logging_level: str = "INFO"

model_config = ConfigDict(env_file=".env", env_file_encoding="utf-8")
model_config = ConfigDict(
env_file=".env",
env_file_encoding="utf-8",
extra="ignore",
)


settings = MarketDataSettings()
11 changes: 10 additions & 1 deletion src/tests/test_client.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import datetime
import os
from unittest.mock import patch

import pytest
Expand All @@ -15,7 +16,7 @@
from marketdata.internal_settings import NO_TOKEN_VALUE
from marketdata.retry import get_retry_adapter
from marketdata.sdk_error import MarketDataClientErrorResult
from marketdata.settings import settings
from marketdata.settings import MarketDataSettings, settings
from marketdata.types import UserRateLimits
from marketdata.utils import format_duration_log

Expand Down Expand Up @@ -316,3 +317,11 @@ def test_client_pre_and_post_request_logs(client, respx_mock):
mock_logger_info.call_args_list[0].assert_called_with(
f"GET 200 000ms 1234567890 {last_request.request.url}"
)


def test_settings_extra_env_vars():
with patch.dict(
os.environ, {"RANDOM_VAR_FOR_TESTING": "123", "MARKETDATA_TOKEN": "test_token"}
):
settings = MarketDataSettings()
assert settings.marketdata_token == "test_token"