This repository was archived by the owner on Jul 14, 2021. It is now read-only.
Open
Conversation
+ moved most of the properties viewer logic to the VM layer + setup the properties viewer logic to call the VM layers + setup the RESTAPI in engine, the properties viewer is now getting info from the engine RESTAPI in engine + stubbed the transform component for front end testing / REST testing + reconstructed the RESTAPI to support localhost communication on chrome
+ working add component / remove component
+ Undo had a bug where it was calling the redo's callback
+ a global static was set up in the Undo/Redo call for other Modules use
Menu Bar:
+ Added View option to the bar, with some stubbed out view options
+ changed the font color to something more readable
Hierarchy Viewer:
+ created an instance of the a golden layout container, this enabled me to use
resize feature for undo/redo testing
+ can now open Properties View + can now open Hierarchy View + can now open Scene View + can now open Project View + can now open Console View All buttons in the "View" dropdown on the Menu Bar are all functional. If the window is not active, you can open a new one. You can only open a new window if there is currently no active window for the one you chose. Only 1 of each window can be active at a time.
Masstronaut
reviewed
Jun 12, 2018
|
|
||
| constructor() { | ||
| this.undoRedoManager = UndoRedoManagerService.getInstance(); | ||
| } |
Owner
There was a problem hiding this comment.
Using a singleton may cause issues later on with multiple editors running on one machine. Noted in issue #48
Masstronaut
reviewed
Jun 12, 2018
| constructor(private http: HttpClient) {} | ||
|
|
||
| getComponentsList() { | ||
| const url = `${this.realEngineURL}/ComponentsList`; |
Owner
There was a problem hiding this comment.
This should be removed as it is satisfied by the component definitions provided by /Components as documented here.
Masstronaut
approved these changes
Jul 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Undo/Redo to the frontend, testing can be done on the Properties View.
You need to run the Engine, with an internet connection, and have the frontend running.
Updated the visuals for the Properties View components:
Added the "View" drop down menu to the Menu Bar