Skip to content

Change Symbol order to have uppercase names before lowercase ones. #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrueter wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −2
Open

Change Symbol order to have uppercase names before lowercase ones. #1680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61cbf57
Change Symbol order to have uppercase names before lowercase ones.
hrueter Feb 5, 2026
590152c
Merge branch 'master' into alph_canonical_ordering
mmatera Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mathics/core/symbols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,9 +562,11 @@ def element_order(self) -> tuple:
if self.is_numeric()
else BASIC_EXPRESSION_ELT_ORDER
),
Monomial({self.name: 1}),
Monomial({str.lower(self.name): 1}),
Copy link
Contributor

@mmatera mmatera Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Monomial({str.lower(self.name): 1}),
Monomial({self.name.lower()+self.name.swapcase(): 1}),

# The canonical in for WL is to sort by lowercase first. Hence we must swap the case.
Monomial({str.swapcase(self.name): 1}),
Copy link
Contributor

@mmatera mmatera Feb 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Monomial({str.swapcase(self.name): 1}),

0,
self.name,
str.lower(self.name),
Copy link
Contributor

@mmatera mmatera Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
str.lower(self.name),
self.name,

1,
)

Expand Down
4 changes: 4 additions & 0 deletions test/builtin/statistics/test_orderstats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ def test_canonical_sort():
"{ByteArray[<1>], F[2]}",
hold_expected=True,
)
check_evaluation(
"Sort[{Mathics,Math,ics,mathics}]",
"{ics, Math, mathics, Mathics}",
)
check_evaluation(
r"Sort[Table[IntegerDigits[2^n], {n, 10}]]",
r"{{2}, {4}, {8}, {1, 6}, {3, 2}, {6, 4}, {1, 2, 8}, {2, 5, 6}, {5, 1, 2}, {1, 0, 2, 4}}",
Expand Down
Loading