add support for commands on Github PRs#2
Merged
code-crusher merged 2 commits intomainfrom Feb 26, 2025
Merged
Conversation
![matter-ai-bot[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The implementation of GitHub PR commands is well-structured and adds valuable functionality. I've suggested a few improvements to enhance error handling, logging, and code organization. These changes will make the code more maintainable and robust.
| * Processes AI analysis output by handling code suggestion blocks properly | ||
| * @param analysis The raw analysis string from the AI | ||
| * @returns Parsed content with code blocks properly restored | ||
| */ |
Contributor
There was a problem hiding this comment.
Suggested change
| */ | |
| * Processes AI analysis output by handling code suggestion blocks properly | |
| * @param analysis The raw analysis string from the AI | |
| * @returns Parsed content with code blocks properly restored | |
| */ | |
| const processAnalysisOutput = (analysis: string): any => { |
| try { | ||
| await addCommentToPullRequest( | ||
| githubToken, | ||
| owner, |
Contributor
There was a problem hiding this comment.
Suggested change
| owner, | |
| } catch (error) { | |
| console.error("Error during PR review:", error); | |
| try { |
|
|
||
| const syncUpdatedEventAndStoreInDb = async (event: any, githubPayload: any) => { | ||
|
|
||
| const installationId: number = githubPayload?.installation?.id |
Contributor
There was a problem hiding this comment.
Suggested change
| const installationId: number = githubPayload?.installation?.id | |
| } catch (error) { | |
| console.error("Error generating PR summary:", error); | |
| // Notify about the error |
| } | ||
| } | ||
|
|
||
| if (eventType === 'issue_comment') { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (eventType === 'issue_comment') { | |
| if (eventType === 'issue_comment') { | |
| const action = eventPayload.action | |
| const issue = eventPayload.issue | |
| const comment = eventPayload.comment | |
| const repo = eventPayload.repository.name | |
| // Only process newly created comments | |
| if (action === 'created') { |
| const comment = eventPayload.comment | ||
| const repo = eventPayload.repository.name | ||
|
|
||
| if (action === 'created') { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (action === 'created') { | |
| // Check for app mentions in the comment | |
| const commentBody = comment.body.toLowerCase(); | |
| const isMentioned = commentBody.includes('/ai'); | |
| const hasReviewCommand = commentBody.includes('review'); | |
| const hasSummaryCommand = commentBody.includes('summary'); |
| if (issue.pull_request) { | ||
| // Check for app mentions in the comment | ||
| const isMentioned = comment.body.includes('/ai'); | ||
| const hasReviewCommand = comment.body.includes('review'); |
Contributor
There was a problem hiding this comment.
Suggested change
| const hasReviewCommand = comment.body.includes('review'); | |
| if (isMentioned) { | |
| console.log(`Processing command in PR #${issue.number}: ${comment.body}`); | |
| if (hasReviewCommand) { |
| }); | ||
|
|
||
| const response = await octokit.issues.createComment({ | ||
| owner, |
Contributor
There was a problem hiding this comment.
Good implementation of the comment addition function with proper error handling.
| } | ||
| }; | ||
|
|
||
| const filterPRFiles = (files: any[]) => { |
Contributor
There was a problem hiding this comment.
Nice utility function for filtering PR files. This helps maintain consistency across the codebase by centralizing this logic.
| // Call the dedicated function to handle the review request | ||
| await handleReviewRequest( | ||
| githubToken, | ||
| owner, |
Contributor
There was a problem hiding this comment.
The command parsing logic is simple but effective. In the future, you might want to consider a more structured approach if more commands are added.
Member
Author
|
/matter summary |
Contributor
|
I'm generating a summary for this PR. I'll post it shortly. |
Contributor
PR Summary: Add Support for Commands on GitHub PRs🔄 What Changed
🔍 Impact of the Change
📁 Total Files Changed
🧪 Test Added
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
How Has This Been Tested?
Screenshots (if applicable)
Checklist
Related Issues