Fix the handling of arguments in the constructor of GridTensor#5
Open
gillioz wants to merge 1 commit intoMauricioSalazare:masterfrom
Open
Fix the handling of arguments in the constructor of GridTensor#5gillioz wants to merge 1 commit intoMauricioSalazare:masterfrom
gillioz wants to merge 1 commit intoMauricioSalazare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current logic, the following call to the constructor of
GridTensordoes not achieve what it should:The reason is that if the keywords
node_file_pathandlines_file_pathare both null, then the default grid is used, instead of using the dataframes passed as arguments.This PR fixes the problem with one line of code.