Fix for a Tag Editor crash with flac files#95
Open
giacomozama wants to merge 1 commit intoMaxFour:masterfrom
Open
Fix for a Tag Editor crash with flac files#95giacomozama wants to merge 1 commit intoMaxFour:masterfrom
giacomozama wants to merge 1 commit intoMaxFour:masterfrom
Conversation
…oTagger that occurs while saving non-linked artworks of flac songs, causing the Tag Editor to crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever the uses saves changes in the Tag Editor, AbsTagEditorActivity calls Tag.setField(Artwork). After that, if Artwork.isLinked() returns false, the FlacTag implementation of Tag causes Artwork.setImageFromData() to be called while creating the field, which throws an UnsupportedOperationException for AndroidArtwok. This change introduces a workaround by creating the field manually and using Tag.setField(TagField) whenever we have to deal with non-linked artworks and FlacTags.
If left the isLinked() check there, even though I'm not sure it's necessary as Music-Player might only create non-linked artworks.