Migrate from RSA to EC (Elliptic Curve) Algorithm for OpenSSL Usage in PHP#28
Merged
Migrate from RSA to EC (Elliptic Curve) Algorithm for OpenSSL Usage in PHP#28
Conversation
… update RSA classes to default to EC Co-authored-by: MayMeow <3164256+MayMeow@users.noreply.github.com>
Co-authored-by: MayMeow <3164256+MayMeow@users.noreply.github.com>
Co-authored-by: MayMeow <3164256+MayMeow@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate from RSA to EC (Elliptic Curve) Algorithm for OpenSSL Usage in PHP
Migrate from RSA to EC (Elliptic Curve) Algorithm for OpenSSL Usage in PHP
Jun 1, 2025
…ec' key for improved structure
…gnment of configArgs
MayMeow
reviewed
Jun 2, 2025
| public function generateKeys(string $passphrase, ?array $configArgs = null, string $salt = 'salt'): RSAParameters | ||
| { | ||
| if ($configArgs !== null) { | ||
| $this->config = $configArgs; |
Contributor
Author
There was a problem hiding this comment.
The current code already replaces configs (line 34: $this->config = $configArgs;) instead of merging them. This was changed in commit de85b51. Is this the desired behavior or did you want me to change it to merge instead?
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a comprehensive migration from RSA to Elliptic Curve (EC) cryptography as the default for better performance and security, while maintaining full backward compatibility.
🚀 Key Changes
Core Migration
New Classes Added
ECParameters- Dedicated EC key generation and managementECCryptoServiceProvider- EC-specific crypto operations with proper limitationsSmart Compatibility Handling
🔧 Usage Examples
Default EC Signing (New Behavior)
Explicit RSA for Encryption (Backward Compatibility)
Dedicated EC Classes
📊 Performance Benefits
If you only use signing/verification: No changes needed - automatically uses faster EC keys.
If you use encryption/decryption:
🧪 Testing
📚 Documentation
🔒 Security & Compatibility Notes
Fixes #27.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
api.github.com/usr/bin/php8.3 -n -c /tmp/P3dYRm /usr/bin/composer install(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.