Added has started, which adds way to check, whether CSSFX has been st…#46
Added has started, which adds way to check, whether CSSFX has been st…#46FlorianKirmaier wants to merge 2 commits intoMcFoggy:masterfrom
Conversation
…arted. Useful to check whether it's active in a production environment, without relying on JVM-Arguments.
| private static boolean isGlobalCssFXStarted = false; | ||
|
|
||
| private static boolean isAnyCssFXStarted = false; | ||
|
|
||
|
|
||
| private static BooleanProperty cssFXStarted = new SimpleBooleanProperty(false); |
There was a problem hiding this comment.
what is the purpose of keeping several states? isn't only one enough?
There was a problem hiding this comment.
isGlobalCssFXStarted prevents starting CSSFX.start() twice - which would end in twice as many listeners.
isAnyCssFXStarted just tells us, whether CSSFX was started in any way.
It's worth noting, that It's not really possible to start CSSFX.
| cssFXStarted.set(true); | ||
|
|
There was a problem hiding this comment.
we lack a cleanup of this state change during stop action
There was a problem hiding this comment.
The stop mechanism doesn't really work.
The listener still stays active.
And it's not really used in any application I know of.
So I would rather suggest removing the stop method.
|
@McFoggy |
|
@FlorianKirmaier I have simplified your work in #47 please have a look. |
2 participants
…arted. Useful to check whether it's active in a production environment, without relying on JVM-Arguments.