Fixes Issue #780: Replaced version component addition with bitwise OR#781
Open
TheAudioGoblin wants to merge 1 commit intoMcMartin:mainfrom
Open
Fixes Issue #780: Replaced version component addition with bitwise OR#781TheAudioGoblin wants to merge 1 commit intoMcMartin:mainfrom
TheAudioGoblin wants to merge 1 commit intoMcMartin:mainfrom
Conversation
…twise OR - Replaced addition (`+`) with bitwise OR (`|`) in `_FRUT_version_to_dec` to correctly pack version components. - Fixes incorrect results caused by addition-related overflow or bit corruption. - Ensures reliable encoding of version numbers for all valid inputs.
Collaborator
|
Hey @McMartin , I guess that the CI errors are not related to TheAudioGoblin changes. I tried to take a look , maybe the macOS vm there were updated (or not because Do you think you could take a look at some point, or maybe we could merge this one as-is since it is a simple change ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+) with bitwise OR (|) in_FRUT_version_to_decto correctly pack version components.