Improve error handling in C and Python API #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonder-sk
reviewed
Dec 18, 2025
Contributor
wonder-sk
left a comment
wonder-sk
left a comment
There was a problem hiding this comment.
let's add postgres driver support too
dvdkon
force-pushed
the
better-error-handling
branch
2 times, most recently
from
c5b481b to
9c5f522
Compare
dvdkon
force-pushed
the
better-error-handling
branch
from
9c5f522 to
4de85e1
Compare
dvdkon
force-pushed
the
better-error-handling
branch
from
8079eca to
4d19281
Compare
wonder-sk
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently geodiff returns a binary status code and optionally prints more detailed error messages to the log. This doesn't give sufficient direct feedback to users, and some have resorted to parsing the log. To give reasonable feedback, I refactored geodiff so that specific exceptions convert to specific return codes, and added a new "last call's error message" buffer that users can check in case of error.
On the Python side, this is converted back to exceptions with the appropriate message.