-
Notifications
You must be signed in to change notification settings - Fork 76
Improve autosync capabilities #4245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gabriel-bolbotina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems fine. I was wondering if we should also add/ update the unit test for this enhancement?
|
@Withalion we have tested the functionality and it seems to work fine, thanks! |
|
@gioman I'm happy to hear that, after some discussion with @tomasMizera we will add some more improvements to the autosync. |
📦 Build Artifacts Ready
|
|
@tomasMizera I fixed the missing banner, but I forgot what were the other issues. I'll fix them when you publish your review |
📦 Build Artifacts Ready
|
|
Change the option description in app settings to something more meaningful |
📦 Build Artifacts Ready
|
tomasMizera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
fixes #4178
This PR adds new triggers for autosync when allowed:
Besides the triggers also UX was improved. With synchronizations triggered by autosync there won't be so much "visual smog" only notification about successful sync will be shown.