Implementing testing api for storage change to limits tests #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add patch to mergin client
- use limits api in project limit hit test to allow run this test separately
MarcelGeo
requested review from
ValentinBuira
and removed request for
VitorVieiraZ
Pull Request Test Coverage Report for Build 11719797122Details
💛 - Coveralls |
Contributor
ValentinBuira
left a comment
ValentinBuira
left a comment
There was a problem hiding this comment.
Looking good to me, just one small comment, and otherwise just suggestion
ValentinBuira
approved these changes
Nov 7, 2024
Contributor
ValentinBuira
left a comment
ValentinBuira
left a comment
There was a problem hiding this comment.
Thanks for the change, looking good now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first usage of testing API for changing storage limits and projects count. Test for storage and project limit hit are now using new api. There is also
test_available_storage_validation2but no validation is performed here (we need to name or remove in future).Other ➕