Skip to content

Conversation

@varmar05
Copy link
Collaborator

@varmar05 varmar05 commented Nov 6, 2025

We want to make new v2/ consistent and keep using v prefix in api request / response. Internally we still use integers but clients would keep using old naming.

@varmar05 varmar05 requested a review from harminius November 6, 2025 07:34
Copy link
Contributor

@harminius harminius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19128231330

Details

  • 20 of 21 (95.24%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 94.456%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/mergin/sync/public_api_v2_controller.py 4 5 80.0%
Totals Coverage Status
Change from base Build 18940537237: -0.009%
Covered Lines: 8485
Relevant Lines: 8983

💛 - Coveralls

@varmar05 varmar05 merged commit f01986e into dev-r85-v2-pull Nov 6, 2025
4 checks passed
@MarcelGeo MarcelGeo deleted the delta_add_v_prefix branch November 13, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants