Feat/mesh value deser ordering #783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a static method
MeshValue.sortValue()to sort CardanoValue(JSON representation) by policy ID and token name using byte ordering. It also simplifies the internalcompareByteOrderfunction from a complex byte-by-byte parsing loop to a simple string comparison, leveraging the fact that hex digits0-9, a-fare in ascending ASCII order.Changes:
compareByteOrderfrom 13 lines to 2 linesMeshValue.sortValue(plutusValue: Value): Valuestatic methodsortValueAffect components
@meshsdk/common@meshsdk/contract@meshsdk/core@meshsdk/core-csl@meshsdk/core-cst@meshsdk/hydra@meshsdk/provider@meshsdk/react@meshsdk/svelte@meshsdk/transaction@meshsdk/walletType of Change
Related Issues
N/A
Checklist
npm run test)npm run build)Additional Information
The
sortValuemethod is useful for ensuring consistent ordering of assets inValuewhen deserializing or constructing values from various sources. Cardano requires values to be sorted by policy ID then token name for transaction validity.