feat(network-controller): connect NetworkController to ConnectivityController
#7627
+597
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
cryptodev-2s
force-pushed
the
feature/connect-network-controller-to-connectivity
branch
from
1a810fe to
b590b43
Compare
cryptodev-2s
changed the title
NetworkController to ConnectivityController
cryptodev-2s
force-pushed
the
feature/connect-network-controller-to-connectivity
branch
from
b590b43 to
1bdba27
Compare
mcmire
reviewed
Jan 14, 2026
| throw new Error('Could not make request to endpoint.'); | ||
| } | ||
|
|
||
| const connectivityState = messenger.call( |
Contributor
There was a problem hiding this comment.
It's fine to add this check just to be absolutely sure that these events aren't published. But I wonder if we should add similar logic to RpcService as well? If the user is offline, and a "connection error" is thrown while making a request, then the request should not be retried. If we do this, then the onDegraded or onBreak callbacks within RpcService should never be called, and therefore neither NetworkController:rpcEndpointDegraded nor NetworkController:rpcEndpointUnavailable should be published.
Contributor
Author
cryptodev-2s
force-pushed
the
feature/connect-network-controller-to-connectivity
branch
from
1bdba27 to
753eb65
Compare
cryptodev-2s
force-pushed
the
feature/connect-network-controller-to-connectivity
branch
2 times, most recently
from
5c3f070 to
35be87b
Compare
Contributor
Author
|
@metamaskbot publish-preview |
cryptodev-2s
force-pushed
the
feature/connect-network-controller-to-connectivity
branch
3 times, most recently
from
3d671df to
be34729
Compare
Contributor
Author
|
@metamaskbot publish-preview |
…ntroller - Add ConnectivityController:getState action handler requirement - Suppress rpcEndpointUnavailable and rpcEndpointDegraded events when offline - Update NetworkController to check connectivity status before publishing events - Add tests for offline event suppression
…fline - Add isOffline check to RpcService retry filter policy to prevent retries when offline - Suppress rpcEndpointUnavailable and rpcEndpointDegraded events when offline - Add tests to verify retries don't happen when offline - Add tests to verify events are suppressed when offline - Update CHANGELOG with breaking change documentation
cryptodev-2s
force-pushed
the
feature/connect-network-controller-to-connectivity
branch
from
e3d5f1f to
d59bf85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Connects
NetworkControllertoConnectivityControllerto suppress RPC endpoint error events when the user is offline.Changes
NetworkController:rpcEndpointUnavailableandNetworkController:rpcEndpointDegradedevents when connectivity status is offlineBreaking Changes
NetworkControllernow requiresConnectivityController:getStateaction handler to be registered on the messengerconnectivityStatusproperty ('online'or'offline')NetworkControllerMessengerReferences
Checklist
Note
Makes RPC behavior offline-aware and updates dependencies/types.
@metamask/connectivity-controller; update messenger to allowConnectivityController:getStateisOfflineinto RPC services; inRpcService, skip retries and circuit-breaker triggers when offlineNetworkController:rpcEndpointUnavailableandNetworkController:rpcEndpointDegradedevents when offlineConnectivityController:getStateREADMEdependency graph,tsconfigreferences,package.json, andyarn.lockConnectivityController:getStateinCHANGELOGWritten by Cursor Bugbot for commit d59bf85. This will update automatically on new commits. Configure here.