Skip to content

Conversation

@coodos
Copy link
Contributor

@coodos coodos commented Dec 7, 2025

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • New Features

    • Added complete eCurrency platform with user authentication via QR code and eID wallet.
    • Implemented currency creation, minting, and management with group-based admin controls.
    • Built ledger and transaction system supporting transfers between user and group accounts.
    • Created dashboard with account balances, transaction history, and account context switching.
    • Added group management with admin roles and multi-account support.
    • Integrated Web3 adapter for external data synchronization.
  • Infrastructure

    • Set up Express-based API with PostgreSQL database and TypeORM ORM.
    • Configured React frontend with Vite, Tailwind CSS, and React Query.
    • Established JWT-based authentication middleware and token management.
    • Implemented Server-Sent Events for real-time authentication updates.

✏️ Tip: You can customize this high-level summary in your review settings.

@coodos coodos marked this pull request as ready for review December 7, 2025 05:32
@coodos coodos merged commit 39f931a into main Dec 7, 2025
2 of 5 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 7, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a new eCurrency platform: a TypeScript Node/Express API (TypeORM + PostgreSQL, JWT, SSE auth, web3 adapter, controllers/services/migrations) and a React + Vite frontend (auth, balances, transfers, currency UIs, Tailwind tooling and build configs).

Changes

Cohort / File(s) Summary
Project manifests & build
platforms/eCurrency-api/package.json, platforms/eCurrency/package.json, platforms/eCurrency/tsconfig.json, platforms/eCurrency-api/tsconfig.json, platforms/eCurrency/postcss.config.js, platforms/eCurrency/tailwind.config.ts, platforms/eCurrency/vite.config.ts
New package/manifests and build configs for backend and frontend (npm scripts, dependencies, TypeScript, Vite, PostCSS/Tailwind).
Server entry & middleware
platforms/eCurrency-api/src/index.ts, platforms/eCurrency-api/src/middleware/auth.ts, platforms/eCurrency-api/src/utils/jwt.ts, platforms/eCurrency-api/src/types/express.ts
Express app bootstrap, auth middleware/guard, JWT utilities, and Request.user type augmentation.
Controllers (HTTP endpoints)
platforms/eCurrency-api/src/controllers/*.ts (AuthController.ts, UserController.ts, GroupController.ts, CurrencyController.ts, LedgerController.ts, WebhookController.ts)
New controllers exposing SSE-based auth, user/profile endpoints, group search/members, currency creation/minting, ledger balances/transfers/history, and webhook handling with mapping/locking logic.
Services (business logic)
platforms/eCurrency-api/src/services/*.ts (UserService.ts, GroupService.ts, CurrencyService.ts, LedgerService.ts)
New service layer: user/group management, currency lifecycle and minting, ledger operations (balances, entries, transfers, history, account init).
Database config, entities & migrations
platforms/eCurrency-api/src/database/data-source.ts, entities/*.ts (User.ts, Group.ts, Currency.ts, Ledger.ts), migrations/*.ts
TypeORM DataSource, entities for users/groups/currencies/ledger (relations, enums), and migrations creating schema and subsequent schema changes (description column, sender/receiver fields).
Web3 adapter & DB event watcher
platforms/eCurrency-api/src/web3adapter/watchers/subscriber.ts, platforms/eCurrency-api/src/web3adapter/index.ts, platforms/eCurrency-api/src/web3adapter/mappings/*.mapping.json
Web3Adapter initialization and PostgresSubscriber to emit web3 events on entity changes with debouncing, mapping files for users/groups/currencies/ledger.
Frontend entry, styling & assets
platforms/eCurrency/client/index.html, platforms/eCurrency/client/src/main.tsx, platforms/eCurrency/client/src/index.css, platforms/eCurrency/client/src/App.tsx
React entry HTML, main render, global Tailwind CSS with theme variables, and top-level App/Router.
Frontend auth & API client
platforms/eCurrency/client/src/lib/* (auth-context.tsx, apiClient.ts, authUtils.ts, utils.ts, utils/mobile-detection.ts)
Auth context (login/logout/hydration), axios client with token injection/401 handling, localStorage auth helpers, small UI/util helpers.
Frontend pages & components
platforms/eCurrency/client/src/pages/*, platforms/eCurrency/client/src/components/* (auth/login-screen, dashboard, currencies, currency-detail, transfer/mint/create/add modals, transaction card/detail, account switcher, user menu, custom number input, etc.)
New UI: QR/SSE login flow, account context switching, currency management, minting, account initialization, transfers, transaction history, modals and form components.
Registry minor update
platforms/registry/src/index.ts
Adds VITE_ECURRENCY_BASE_URL to the platforms list and minor formatting changes.

Sequence Diagram(s)

sequenceDiagram
  participant Client (Browser)
  participant Frontend App
  participant Server (AuthController)
  participant DB (Postgres/User repo)
  participant EventEmitter

  Client->>Frontend App: open /auth -> request /api/auth/offer
  Frontend App->>Server: GET /api/auth/offer
  Server->>DB: (optional) generate sessionId, persist session metadata
  Server-->>Frontend App: 200 { sessionId, offerUrl, qr }
  Frontend App->>Client: render QR / deep link
  Note right of Server: SSE subscription endpoint exists
  Client->>Server: open EventSource /api/auth/sse?session=...
  Server->>EventEmitter: subscribe to session events
  Note over EventEmitter,DB: external wallet posts to Server/login (or external flow)
  Server->>DB: validate login (find user)
  Server->>EventEmitter: emit session event with token+user
  EventEmitter-->>Server: deliver event to subscribed SSE connection
  Server-->>Client: SSE event: { token, user }
  Client->>Frontend App: store token/user and redirect to /dashboard
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

  • Focus review on: LedgerService.transfer and balance accounting, migration correctness vs. entities (enums, FK constraints), WebhookController mapping and locking, PostgresSubscriber debouncing/relations logic, SSE auth lifecycle and token issuance.

Possibly related PRs

  • Feat/w3ds evoting #290 — Adds similar SSE-based auth flows and matching client login components (high overlap in auth/websocket/SSE patterns).

Suggested labels

evault-refactor

Suggested reviewers

  • sosweetham
  • xPathin

Poem

🐰 I found a ledger in the glade,
Coins and branches neatly laid,
QR beams and webhooks play,
I hop, I mint, I share—hooray!
A tiny rabbit codes the day.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/ecurrency

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d94cea and cda5921.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (60)
  • platforms/eCurrency-api/package.json (1 hunks)
  • platforms/eCurrency-api/src/controllers/AuthController.ts (1 hunks)
  • platforms/eCurrency-api/src/controllers/CurrencyController.ts (1 hunks)
  • platforms/eCurrency-api/src/controllers/GroupController.ts (1 hunks)
  • platforms/eCurrency-api/src/controllers/LedgerController.ts (1 hunks)
  • platforms/eCurrency-api/src/controllers/UserController.ts (1 hunks)
  • platforms/eCurrency-api/src/controllers/WebhookController.ts (1 hunks)
  • platforms/eCurrency-api/src/database/data-source.ts (1 hunks)
  • platforms/eCurrency-api/src/database/entities/Currency.ts (1 hunks)
  • platforms/eCurrency-api/src/database/entities/Group.ts (1 hunks)
  • platforms/eCurrency-api/src/database/entities/Ledger.ts (1 hunks)
  • platforms/eCurrency-api/src/database/entities/User.ts (1 hunks)
  • platforms/eCurrency-api/src/database/migrations/1765035161362-migration.ts (1 hunks)
  • platforms/eCurrency-api/src/database/migrations/1765039149572-migration.ts (1 hunks)
  • platforms/eCurrency-api/src/database/migrations/1765044585971-migration.ts (1 hunks)
  • platforms/eCurrency-api/src/index.ts (1 hunks)
  • platforms/eCurrency-api/src/middleware/auth.ts (1 hunks)
  • platforms/eCurrency-api/src/services/CurrencyService.ts (1 hunks)
  • platforms/eCurrency-api/src/services/GroupService.ts (1 hunks)
  • platforms/eCurrency-api/src/services/LedgerService.ts (1 hunks)
  • platforms/eCurrency-api/src/services/UserService.ts (1 hunks)
  • platforms/eCurrency-api/src/types/express.ts (1 hunks)
  • platforms/eCurrency-api/src/utils/jwt.ts (1 hunks)
  • platforms/eCurrency-api/src/web3adapter/index.ts (1 hunks)
  • platforms/eCurrency-api/src/web3adapter/mappings/currency.mapping.json (1 hunks)
  • platforms/eCurrency-api/src/web3adapter/mappings/group.mapping.json (1 hunks)
  • platforms/eCurrency-api/src/web3adapter/mappings/ledger.mapping.json (1 hunks)
  • platforms/eCurrency-api/src/web3adapter/mappings/user.mapping.json (1 hunks)
  • platforms/eCurrency-api/src/web3adapter/watchers/subscriber.ts (1 hunks)
  • platforms/eCurrency-api/tsconfig.json (1 hunks)
  • platforms/eCurrency/client/index.html (1 hunks)
  • platforms/eCurrency/client/src/App.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/account-context-switcher.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/auth/login-screen.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/currency/add-currency-account-modal.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/currency/create-currency-modal.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/currency/mint-currency-modal.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/currency/transaction-card.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/currency/transaction-detail-modal.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/currency/transfer-modal.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/ui/custom-number-input.tsx (1 hunks)
  • platforms/eCurrency/client/src/components/user-menu-dropdown.tsx (1 hunks)
  • platforms/eCurrency/client/src/hooks/useAuth.ts (1 hunks)
  • platforms/eCurrency/client/src/index.css (1 hunks)
  • platforms/eCurrency/client/src/lib/apiClient.ts (1 hunks)
  • platforms/eCurrency/client/src/lib/auth-context.tsx (1 hunks)
  • platforms/eCurrency/client/src/lib/authUtils.ts (1 hunks)
  • platforms/eCurrency/client/src/lib/utils.ts (1 hunks)
  • platforms/eCurrency/client/src/lib/utils/mobile-detection.ts (1 hunks)
  • platforms/eCurrency/client/src/main.tsx (1 hunks)
  • platforms/eCurrency/client/src/pages/auth-page.tsx (1 hunks)
  • platforms/eCurrency/client/src/pages/currencies.tsx (1 hunks)
  • platforms/eCurrency/client/src/pages/currency-detail.tsx (1 hunks)
  • platforms/eCurrency/client/src/pages/dashboard.tsx (1 hunks)
  • platforms/eCurrency/package.json (1 hunks)
  • platforms/eCurrency/postcss.config.js (1 hunks)
  • platforms/eCurrency/tailwind.config.ts (1 hunks)
  • platforms/eCurrency/tsconfig.json (1 hunks)
  • platforms/eCurrency/vite.config.ts (1 hunks)
  • platforms/registry/src/index.ts (4 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants