Fix/evault access guard permission issue #646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughIntroduces comprehensive infrastructure and authentication overhaul: adds Docker Compose configurations for core and social services with updated Node.js base images (18→20), adds Bearer token authentication to eVault-core GraphQL operations, removes provisioning-related entities and services, and expands Docker management scripts in package.json. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant GraphQL as GraphQL Server
participant Guard as VaultAccessGuard
participant Resolver as Resolver Logic
participant DB as Database
Client->>GraphQL: GraphQL Query/Mutation
Note over GraphQL: Inspect operation type
alt Store Operation (storeMetaEnvelope)
GraphQL->>Guard: validateAuthentication(context, true)
Guard->>Guard: Check X-ENAME header
alt X-ENAME present & non-empty
Guard->>Guard: Extract eName
rect rgb(200, 220, 200)
Note over Guard: Optional: parse Bearer token
end
Guard->>GraphQL: ✓ Auth passed
else X-ENAME missing/empty
Guard->>GraphQL: ✗ Throw error
GraphQL->>Client: 401 Unauthorized
end
else Read/Update Operation
GraphQL->>Guard: validateAuthentication(context, false)
Guard->>Guard: Check Authorization header
alt Valid Bearer token
Guard->>Guard: Validate JWT
rect rgb(200, 220, 200)
Note over Guard: Extract tokenPayload
end
Guard->>GraphQL: ✓ Auth passed
GraphQL->>Resolver: Execute resolver
Resolver->>DB: Perform operation
DB->>Resolver: Return data
Resolver->>GraphQL: Return result
GraphQL->>Client: 200 Result
else No token or invalid token
Guard->>GraphQL: ✗ Throw error
GraphQL->>Client: 401 Unauthorized
end
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (31)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sosweetham
approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
closes #645
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.