fix: include link for eID App

[Bekiboo]

Description of change

Use the proper getAppStoreLink() as in the other platforms to get the right link for the eID app.

Issue Number

Closes #639

Type of change

• Fix (a change which fixes an issue)

How the change has been tested

Change checklist

• I have ensured that the CI Checks pass locally
• I have removed any unnecessary logic
• My code is well documented
• I have signed my commits
• My code follows the pattern of the application
• I have self reviewed my code

Summary by CodeRabbit

• New Features

  • The eID App reference in the authentication flow is now a clickable link to the App Store, opens in a new tab, and includes improved accessibility labeling.

• Style

  • Updated the CTA button gradient styling for the non-mobile login area to refresh its visual appearance.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Converted the non-mobile QR login prompt's “eID App” text into an external hyperlink to the app store (opens in a new tab with proper rel/aria attributes) and changed a CTA button's gradient utility class name in the same auth page file.

Changes

Cohort / File(s)	Summary
Auth UI — link & CTA platforms/pictique/src/routes/(auth)/auth/+page.svelte	Replaced plain “eID App” text with an anchor linking to getAppStoreLink() (new tab, rel="noopener noreferrer", aria-label) in the non-mobile QR flow; updated CTA gradient class from bg-gradient-to-r to bg-linear-to-r.

Sequence Diagram(s)

(omitted — change is a localized UI tweak without multi-component control-flow requiring a sequence diagram)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Feat/mobile responsiveness #292: Modifies the same auth page and mobile/non-mobile login flows; likely overlaps with this UI/link change.
• chore: make applications reject older wallets #424: Alters the same +page.svelte login/link behavior and related deep-link logic; strongly related.

Suggested reviewers

• coodos
• sosweetham

Poem

🐰
A tiny hop, a click appears,
Where plain text once drew silent stares.
“eID App” now opens doors afar,
A link that points to where apps are.
Tap the CTA — the gradient’s new — hooray!

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The gradient background change from 'bg-gradient-to-r' to 'bg-linear-to-r' appears unrelated to the stated objective of adding an eID App link and should be justified or removed.	Clarify the purpose of the gradient background utility change or revert it to keep changes focused on the eID App link requirement from issue #639.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: include link for eID App' directly describes the main change: making eID App text clickable by adding a proper link.
Description check	✅ Passed	The description follows the template structure with all required sections completed: change description, issue number (#639), type of change (Fix), and filled checklist items.
Linked Issues check	✅ Passed	The PR implements the core requirement from issue #639: making 'eID App' text clickable by wrapping it in a hyperlink using getAppStoreLink(), which directly addresses the bug of plain text not being clickable on desktop.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

Fix all issues with AI Agents 🤖

In @platforms/pictique/src/routes/(auth)/auth/+page.svelte:
- Around line 154-156: The anchor that calls getAppStoreLink() uses
target="_blank" without rel attributes; update the <a> element wrapping
getAppStoreLink() to include rel="noopener noreferrer" to prevent window.opener
exposure and add an aria-label (eg. aria-label="Open eID App store in new tab")
to indicate it opens in a new tab for accessibility; ensure the change is
applied to the anchor containing getAppStoreLink() and preserve the existing
target="_blank" and styling.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

platforms/pictique/src/routes/(auth)/auth/+page.svelte (1)

4-6: Remove unused constant imports.

The constants PUBLIC_APP_STORE_EID_WALLET and PUBLIC_PLAY_STORE_EID_WALLET are imported but never used. The getAppStoreLink() function (lines 24-36) uses hardcoded app store URLs instead of these environment variables.

🧹 Nitpick comments (1)

platforms/pictique/src/routes/(auth)/auth/+page.svelte (1)

152-152: Consider adding rel="noopener noreferrer" to the mobile branch for consistency.

While the mobile branch (line 152) doesn't use target="_blank", if you later decide to open links in new tabs on mobile as well, remember to include the rel attribute for security. The current mobile implementation is fine since app store links typically launch the native app store.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db6ea53 and 23fcb83.

📒 Files selected for processing (1)

• platforms/pictique/src/routes/(auth)/auth/+page.svelte

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

[coderabbitai]

Actionable comments posted: 1

Fix all issues with AI Agents 🤖

In @platforms/pictique/src/routes/(auth)/auth/+page.svelte:
- Line 173: Replace the invalid Tailwind class "bg-linear-to-r" with the correct
"bg-gradient-to-r" in the element that currently has class="rounded-xl
bg-linear-to-r from-[#4D44EF] via-[#F35B5B] to-[#F7A428] px-8 py-4 text-base
font-semibold text-white transition-opacity hover:opacity-90" so the gradient
utilities (from/via/to) render properly; search for the "bg-linear-to-r" token
in the +page.svelte component and update it to "bg-gradient-to-r".

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23fcb83 and a9695c1.

📒 Files selected for processing (1)

• platforms/pictique/src/routes/(auth)/auth/+page.svelte

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build

🔇 Additional comments (1)

platforms/pictique/src/routes/(auth)/auth/+page.svelte (1)

154-159: LGTM! Successfully addresses issue #639.

The "eID App" text is now properly wrapped in a hyperlink with all necessary security and accessibility attributes. This resolves the issue where the text was not clickable on desktop browsers.