Add parameter for exec timeout #19
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an exec timeout for all the exec resources. The default timeout is 300 seconds and can be overwritten with the parameter
exec_timeout(example:exec_timeout => 3600). This will resolve #17. Also, the issue #18 was fixed in this pull request so issue #18 can be closed:https://github.com/MiamiOH/puppet-duo_authproxy/pull/11. I also set the correctauthproxy.cfgconfig file owner per the duo auth proxy documentation. In addition to adding the exec timeout parameter I also fixed some pdk validation issues for:This pull request also fixes unit test for the
config_spec.rb. Since you set the content as Sensitive, in the unit test, specifying an actual content causes the unit test to fail perpdk test unit --parallel. See below:Lastly, I also fixed some deprecation warnings as well. See below:
All pdk validation and unit tests passes with no issues now.
Let me know if you have any questions.