Open
Conversation
When using --version skip, the hash was still being updated because update_hash defaulted to True. This caused unwanted changes and broken commit messages showing 'version -> None'. Since skipping version detection implies no version change occurred, we should also skip hash updates - the source hasn't changed, so there's no reason to recalculate the hash. Fixes the case where running nix-update with --version skip on an already up-to-date package would still modify the nix file.
When running nix-update on many packages in batch with --build --commit, unchanged packages were still being built, wasting significant time. Move the build step to after change detection so that --build only triggers when the package was actually updated. Interactive commands (--run, --shell) still run immediately since the user explicitly requested them. This significantly speeds up batch updates of many packages where most are already at the latest version. Closes: #497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.