fix: require minimum 2 players to prevent infinite loop#29
Merged
MightyT-2 merged 1 commit intoMightyT-2:mainfrom Feb 15, 2026
Merged
Conversation
When a user typed "!" immediately with fewer than 2 players, the imposter count prompt entered an infinite loop because `imposterCount > len(Player.playerList) / 2` with 0 players evaluates to `imposterCount > 0`, which combined with `imposterCount <= 0` is always true. The fix validates that at least 2 players exist before allowing the user to exit the player entry loop.
LakshmiSravya123
force-pushed
the
fix/28-minimum-player-count
branch
from
e4ac0c8 to
eeb0da7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
len(Player.playerList) / 2 = 0, making the while conditionimposterCount <= 0 or imposterCount > 0always trueCloses #28
Test plan