Skip to content

Fix CI build failures by resolving linting errors#8

Draft
Copilot wants to merge 3 commits intomasterfrom
copilot/remove-vercel-dependency
Draft

Fix CI build failures by resolving linting errors#8
Copilot wants to merge 3 commits intomasterfrom
copilot/remove-vercel-dependency

Conversation

Copy link

Copilot AI commented Oct 28, 2025

The build was failing in CI due to linting errors when CI=true is set (standard in CI environments). No Vercel dependencies were present in the project.

Changes

  • Accessibility fixes

    • Replaced <a onClick> with <button> in Download.js for keyboard accessibility
    • Changed Navbar home link from href="#" to href="#home"
  • React Hooks compliance

    • Removed unused imports (useState, tf) from ProjectsExtended.js
    • Moved runCoco and detect functions inside useEffect to resolve dependency warnings
    • Added cleanup function to clear setInterval on unmount, preventing memory leak
// Before: setInterval without cleanup
useEffect(() => {
  runCoco();  // Causes dependency warning
}, [runCoco]);

// After: proper cleanup
useEffect(() => {
  const runCoco = async () => {
    const intervalId = setInterval(() => detect(net), 10);
    return intervalId;
  };
  
  let intervalId;
  runCoco().then(id => { intervalId = id; });
  
  return () => { if (intervalId) clearInterval(intervalId); };
}, []);

Build now completes successfully with npm run build.

Original prompt

remove vercel dependency and to build without it.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits October 28, 2025 01:09
Co-authored-by: MiguelCoding <40774151+MiguelCoding@users.noreply.github.com>
Co-authored-by: MiguelCoding <40774151+MiguelCoding@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove Vercel dependency and enable building without it Fix CI build failures by resolving linting errors Oct 28, 2025
Copilot AI requested a review from MiguelCoding October 28, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants