Multi exotic selection and similar build clustering#183
Draft
nznaza wants to merge 19 commits intoMijago:betafrom
Draft
Multi exotic selection and similar build clustering#183nznaza wants to merge 19 commits intoMijago:betafrom
nznaza wants to merge 19 commits intoMijago:betafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the selection of multiple exotics for the builder.
Algorithm changes
The algorithm for the build permutations is the same, other than minor changes from the supposition we only had 1 exotic desired.
The limits of the stat selection are the same as when any exotic (or not one in particular) is selected, that is, it will show the max stats, regardless if only one build can achieve it.
This adds no extra calculations nor memory usage.
For the build clustering.
It generates a singular 64 bit number for the hashing.
The added logic is achieved in O(n) time (the small penalty of calculating the hash and other small logic + adding the # of same armor occurrences to each result).
The sorting at the end is intended to keep clusters together even when other sorts are selected. Should be O(n Log n) sort. with the bulk of the time added by the sorting, which js is optimized at.
The extra memory is small since it adds only 8 bytes from the Hash, and other 8 from the repeat number, with the security features that's a bit over 1.5MB
Other comments
The selection for exotic is the same as was already present, just fixed, press shift to select/deselect exotics,
I'm a function over form kind of person, this works for me, but if a better interface is proposed, welcome.