Fix missing icons for some codes, switch to secondaryOverlay icon for all emblems, fix typo#3
Open
FlaminSarge wants to merge 1 commit intoMijago:masterfrom
Open
Fix missing icons for some codes, switch to secondaryOverlay icon for all emblems, fix typo#3FlaminSarge wants to merge 1 commit intoMijago:masterfrom
FlaminSarge wants to merge 1 commit intoMijago:masterfrom
Conversation
… all emblems, fix typo
Author
|
I need to doublecheck the hashes after the rebase. |
Owner
|
Hi, sorry, I did not get any notification email for the PRs in this repository. I will have a look next week, though! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General fixup of codes.ts.
Note that the data was mostly-auto-fetched using the following, with some manual fixes for e.g. M:\Start requiring double \:
https://gist.github.com/FlaminSarge/d8d7286ff26f2a5745c5bbe9f8677f46
Ideally the app itself could do this kind of fetch, but Bungie may not enjoy 20+ requests to their single-item endpoint at once any time anyone visits the page (since they recommend fetching and storing the manifest).