This repository was archived by the owner on Jul 1, 2018. It is now read-only.
Open
Conversation
It's a lot faster
"Outside requests" (i.e. those that aren't made to the app itself) are disabled in the test environment.
Collaborator
Author
|
@codeByScott This is mostly done now, I just need to add one spec that checks to make sure the factories are valid. I'll have to wait to do that until after PR #41 is merged because that PR adds factory bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't ready to be merged yet - I'm testing to make sure the new JS driver works on Semaphore
Resolves #37