Skip to content

Conversation

@MightyKnight
Copy link

@MightyKnight MightyKnight commented Apr 18, 2025


IMPORTANT: You may want to create a new branch. I noticed you have different branches for different versions, and this is a MAJOR change.
I will then change the target of the PR.


Hi Minenash,
I updated PickBlockState to the newest version, hope it helps.
Took me longer than expected to figure out how to do this, since so much changed in the game code, but finally works. 😄

Version update

The block picking functionality was moved from the client fully to the server in vanilla.

Thus, I now wrap the call to getPickStack inside the function onPickItemFromBlock from ServerPlayNetworkHandler.
There is also no need to check for creative anymore, as the includeData flag in vanilla is used for that.

In my testing everything worked as before.

Tooling

I had to update Gradle since newer Loom require it. Used ./gradlew wrapper --gradle-version latest to do that.

During that, I also fixed all the deprecation warnings in the build.gradle and and updated it and settings.gradle to match the newest version from the Fabric example mod.

Using the '/gradlew wrapper --gradle-version latest' command.
All build files were updated to fix deprecated things and reflect the Fabric example mod.
@MightyKnight MightyKnight mentioned this pull request Apr 18, 2025
@MightyKnight
Copy link
Author

Hi @Minenash, hope you're doing good today.
Can you please merge and upload this version to Modrinth? Sorry for the bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant