Update to 1.21.4/1.21.5, fixes #4 #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: You may want to create a new branch. I noticed you have different branches for different versions, and this is a MAJOR change.
I will then change the target of the PR.
Hi Minenash,
I updated PickBlockState to the newest version, hope it helps.
Took me longer than expected to figure out how to do this, since so much changed in the game code, but finally works. 😄
Version update
The block picking functionality was moved from the client fully to the server in vanilla.
Thus, I now wrap the call to
getPickStackinside the functiononPickItemFromBlockfromServerPlayNetworkHandler.There is also no need to check for creative anymore, as the
includeDataflag in vanilla is used for that.In my testing everything worked as before.
Tooling
I had to update Gradle since newer Loom require it. Used
./gradlew wrapper --gradle-version latestto do that.During that, I also fixed all the deprecation warnings in the
build.gradleand and updated it andsettings.gradleto match the newest version from the Fabric example mod.