Open
Conversation
- Created the basic intake code systems for the TalonFX and simulation - Basic functions started
- Repurposing last years code to this years Intake.java - Completed IntakeIOSim and IntakeIOTalonFX
From Reefscape-IO-Restructuring
- Finished repurposing last years code to this years intake
- added constants
- added a SparkMaxIO system just in case (as requested by Rafael)
- IMPORTANT: added constants for intake files in constants, IntakeConstants with values that hold zero (as of now)
- IMPORTANT: device id's have not been decided
- IMPORTANT: the speed in which the fuel enters the robot has not been decided
- added comments - transfered motor ID's to the Intake Constants class
rafaelbaird
requested changes
Jan 23, 2026
Contributor
rafaelbaird
left a comment
rafaelbaird
left a comment
There was a problem hiding this comment.
Some minor fixes, mostly looks good.
| public static final double INTAKE_STALL_CURRENT = 0.0; //TODO: set this number | ||
| public static final int MOTOR_ID = -1; //TODO: set the device id | ||
| public static final | ||
|
|
Contributor
There was a problem hiding this comment.
I know it says otherwise in the style guide, I'll have to fix that. Instead of putting the class IntakeConstants directly in the Constants.java, can you make it a separate file in the constants folder?
| IntakeConstants.INTAKE_FUEL_SPEED), | ||
| this).withTimeout(2).finallyDo(() -> { | ||
| io.stop(); | ||
| }); |
Contributor
There was a problem hiding this comment.
you don't want a timeout here
|
|
||
| TalonFXConfiguration config = new TalonFXConfiguration(); | ||
|
|
||
| private static final double MAX_SPEED = 2000; |
|
|
||
| @Override | ||
| public void stop() {} | ||
| } |
Contributor
There was a problem hiding this comment.
For the three methods above, you need to actually write them.
Desc: - fixed the stuff rafael told me to :D
Desc: - Made IntakeConstants its own file - fixed bugs in code - added stuff rafael told me to change/add
Added a real sim Refactored the code to match other subsystems Fixed errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: a lot of this code cannot be run due to the dummy variables as stated in section II
Section I:
Added intake classes, including the new IO systems
- Added IntakeIO, IntakeIOSim, IntakeIOTalonFX, and IntakeIOSparkMax (depending on what motor we end up using)
Added basic subsystem Intake classes
Section II:
Added static variables in Constants (IntakeConstants)
- (IMPORTANT: many variables have dummy numbers/tbd)
- All variables are public static final __ (number type)
Basic implementation of command for the motor(s) [hopefully not]
- commands like intakeCommand, outtakeCommand, unjamCommand (used if intake system is jammed)
-