Skip to content

Intake-Pivot Subsystem/Base#8

Open
theirisproject wants to merge 8 commits intomainfrom
intake-pivot
Open

Intake-Pivot Subsystem/Base#8
theirisproject wants to merge 8 commits intomainfrom
intake-pivot

Conversation

@theirisproject
Copy link

IMPORTANT: many variables and constants are undefined
Description:

  • Created subsystem pivot/intakepivot
    • Created Pivot, PivotIO, PivotIOSim, PivotIOTalonFX
    • Added more constants under "public class PivotConstants"
    • IMPORTANT: in tandem with IntakeConstants, PivotConstants hold all dummy numbers and need to be defined
  • Added commands (some aren't used :( )

- Created Pivot, PivotIO, PivotIOSim, PivotIOTalonFX
- Pivot, PivotIO are done
- PivotIOSIm and PivotIOTalonFX are not done
- PivotIOTalonFX has no code in yet
Desc:
- Created/finished PivotIOTalonFX with others
- added more constants
- fixed MANY errors
theirisproject and others added 3 commits January 27, 2026 15:24
Desc: removed some descriptions
Basically, PID should be in the subsystem class. I learned IO wrong initially, and this was my bad, so I corrected it by just formatting things around.
@mfriedman-brick mfriedman-brick self-requested a review January 31, 2026 14:58
}

public void joystickControl() {
double voltage = Math.pow(MathUtil.applyDeadband(RobotContainer.operatorController.getRightY(), 0.04), 3) * 12;
Copy link
Contributor

@mfriedman-brick mfriedman-brick Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getRightY() on the operator controller is already used for the hood.

Copy link
Contributor

@mfriedman-brick mfriedman-brick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Desc:
- added PivotVisualization for PivotIOSIm
- some commands changed due to buildrobotcode
Desc:
- Logging from main needed for pivot visualization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants