Skip to content

refactor: add impl methods for abstract bases#151

Merged
giubacc merged 1 commit intoMoonyFringers:mainfrom
giubacc:refactor/impl-methods
Feb 16, 2026
Merged

refactor: add impl methods for abstract bases#151
giubacc merged 1 commit intoMoonyFringers:mainfrom
giubacc:refactor/impl-methods

Conversation

@giubacc
Copy link
Member

@giubacc giubacc commented Feb 10, 2026

Summary

  • Refactor ABCs to delegate public methods to *_impl abstract methods.
  • Update Docker Compose env/service and factories/completion managers accordingly.
  • Add start_impl hook to Environment and adjust defaults.

Testing

  • pytest
  • pre-commit run --all-files
  • black -v src
  • isort src

Fixes #150

@giubacc giubacc self-assigned this Feb 10, 2026
@giubacc giubacc added the enhancement New feature or request label Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 92.47312% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/environment/environment.py 83.78% 6 Missing ⚠️
src/service/service.py 96.55% 1 Missing ⚠️
Flag Coverage Δ
unittests 86.96% <92.47%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/completion/completion.py 92.98% <100.00%> (ø)
src/completion/completion_env.py 87.34% <100.00%> (ø)
src/completion/completion_mng.py 72.72% <100.00%> (+6.06%) ⬆️
src/completion/completion_probe.py 74.28% <100.00%> (ø)
src/completion/completion_svc.py 85.83% <100.00%> (ø)
src/docker/docker_compose_env.py 90.00% <100.00%> (-0.10%) ⬇️
src/docker/docker_compose_svc.py 85.59% <100.00%> (ø)
src/factory/shpd_env_factory.py 83.33% <100.00%> (ø)
src/factory/shpd_svc_factory.py 94.73% <100.00%> (+0.29%) ⬆️
src/service/service.py 88.03% <96.55%> (+1.43%) ⬆️
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giubacc giubacc added this to shepherd Feb 10, 2026
@giubacc giubacc moved this to In Progress in shepherd Feb 10, 2026
@giubacc giubacc added this to the 0.1.0 milestone Feb 10, 2026
@giubacc giubacc marked this pull request as draft February 10, 2026 17:29
@giubacc giubacc force-pushed the refactor/impl-methods branch from ff7dad0 to 01cae77 Compare February 10, 2026 20:23
Fixes MoonyFringers#150

Signed-off-by: Giuseppe Baccini <giuseppe.baccini@live.com>
@giubacc giubacc force-pushed the refactor/impl-methods branch from 01cae77 to 6db1e7a Compare February 15, 2026 18:23
@giubacc giubacc marked this pull request as ready for review February 15, 2026 18:24
@giubacc giubacc requested review from feed3r and luca-c-xcv February 15, 2026 18:24
@giubacc
Copy link
Member Author

giubacc commented Feb 15, 2026

@codex review

@giubacc giubacc moved this from In Progress to In Review in shepherd Feb 15, 2026
@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@feed3r feed3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giubacc giubacc merged commit d6e149c into MoonyFringers:main Feb 16, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in shepherd Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[FEATURE] Refactor ABCs to use impl_* methods

2 participants