Update CMakeLists.txt #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Owner
|
Hi, sorry for the delay, I've been away from home for a few days. The pull request looks good, thanks for putting in the work 👍 As for whether the flags are necessary: I know that I plan to remove support for old compilers and to break some retrocompatibility in cpp-sort 2.0.0, on which I've been working for a few years, so for now I'm fine with being conservative and going the extra mile to let the 1.x.y branch target older compilers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227
I think these are generally desirable defaults, but I don't like imposing any flags on dependent projects. However, I haven't tested whether
/permissive-and/or/Zc:preprocessorare even necessary with more recent versions of MSVC, but I guess we can still impose these MSVC options for backwards compatibility. If I find some time in the future to test this, I'll let you know and maybe we can only impose these options up to a certainMSVC_VERSION.