Change manifest.firefox.json to use optional_host_permissions

[jrmuizel]

This matches what manifest.safari.json and manifest.chrome.json do.

[gemini-code-assist]

Summary of Changes

Hello @jrmuizel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes how host permissions are declared in the Firefox browser manifest by transitioning from mandatory to optional host permissions. This change ensures uniformity with existing manifest configurations for Chrome and Safari, streamlining permission management across different browser environments.

Highlights

• Manifest File Update: The manifest.firefox.json file has been updated to use optional_host_permissions instead of host_permissions.
• Cross-Browser Consistency: This change aligns the Firefox manifest with the existing manifest.safari.json and manifest.chrome.json files, promoting consistency across browser implementations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[jrmuizel]

optional_host_permissions was added to Firefox 128

[gemini-code-assist]

Code Review

This pull request updates manifest.firefox.json to use optional_host_permissions instead of host_permissions, and adds a missing newline at the end of the file. Using optional host permissions is a great improvement for user privacy, as it allows the extension to request permissions on-demand instead of requiring broad access at installation time. This change also brings the Firefox manifest in line with the configurations for Chrome, Safari, and Opera. The existing code appears to correctly handle runtime permission requests. The changes are solid. As a suggestion for future work, you could consider making a similar change to manifest.edge.json to ensure consistency across all browser targets.