Don't crash if $pc is not readable#497
Open
gsingh93 wants to merge 1 commit intoMozillaSecurity:masterfrom
Open
Don't crash if $pc is not readable#497gsingh93 wants to merge 1 commit intoMozillaSecurity:masterfrom
gsingh93 wants to merge 1 commit intoMozillaSecurity:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 77.93% 77.93% -0.01%
==========================================
Files 126 126
Lines 11979 11981 +2
==========================================
+ Hits 9336 9337 +1
- Misses 2643 2644 +1
Continue to review full report at Codecov.
|
Author
|
@choller thoughts on this? |
Author
|
ping @choller |
Contributor
|
@jschwartzentruber may probably be a better person for now? |
Contributor
|
@gsingh93 Thanks for fixing this. Do you have an example log so we can add a test? I worry that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the program counter points to a non-readable memory address after a crash. When we run the
gdb_cmds.txtfile in funfuzz, commands likex/8i $pcwill fail. I'm not sure if this is the right solution, but I just check for the text 'Error in sourced command file' in thecrashInstructionvariable and set the instruction toNoneso it's ignored. I tested this locally and it seems to work.Fixes #496.