Apply scaling checks on NMN Design Toolkit tests #180
Open
jarsarasty wants to merge 36 commits intomainfrom
Open
Apply scaling checks on NMN Design Toolkit tests #180jarsarasty wants to merge 36 commits intomainfrom
jarsarasty wants to merge 36 commits intomainfrom
Conversation
…s greater than max value
jarsarasty
changed the title
jarsarasty
requested review from
FJanssen-TNO,
KobusVanRooyen and
jimrojerTNO
as code owners
Collaborator
|
@jarsarasty Just a reminder to update the CHANGELOG as well |
handle skipped tets in test_runner flake8 style fix change name test_runner exclude test for time test prifiling and test time report excluding scaling tests cache goal programming model using CachingQPSol remove scaling checnks that take too long passing tests clean up
Collaborator
Author
|
Hi @KobusVanRooyen and @FJanssen-TNO , Scaling checks have been excluded from some of the tests, as discussion in our last email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #140, scaling range checks have been added to the NMN Design Tookit tests:
Scaling checks have been included in the following test functions:
The currently implemented checks assume that the minimum scaling range values are non-negative.
The `test_runner.py' script can be used to automatically obtain the benchmark scaling range data of new or modified models. These range data values are stored in the test_scaling_data folder.
In cases where the minimum value of the scaling range is greater than the maximum value, the test is skipped because the minimum and maximum values were probably recorded in the wrong order. This situation can occur when different test models are created and run in the same test method (for example, test_end_scenario_sizing_staged).