Organizational Entities and financial flows between them by jimrojerTNO · Pull Request #21 · Multi-Energy-Systems-Optimization/mesido

jimrojerTNO · 2024-04-10T11:41:33Z

This PR is still in draft state

This PR is meant to do the following:

Add the parsing of the isOwnedBy in ESDL and storing it in the parameters
Finding the points in the energy system where owners change and create cost/revenue variables for exchange of energy between the owners
For this we need to know which carrier they are exchanging and for that we need to know the carrier at every port, therefore a carrier_id parameter is added for each port type.
We need to be able to find how assets connect to each other, previously this was only saved in the constraints, but not in a readeable map, therefore the get_connections() method from the esdl parsing was added.
We assume that the cost/revenue is according to the price(-profile) for that carrier.

…rier at every port in the network and instantiating the required revenue and cost variables

… we need to give it the correct sign

… now add variables and constriants for computing the profit on owner level

KobusVanRooyen · 2024-04-16T08:42:12Z

@jimrojerTNO create some comment block in creating revenue variables in financial mixin. Afterwards review Femke/Kobus

FJanssen-TNO

I've commented some suggestion on how to generalise/improve the code, to speed it up and make less copies of code due to different commodities.
Maybe we should discuss this.

FJanssen-TNO · 2024-04-24T11:29:57Z

src/mesido/esdl/esdl_heat_model.py

+                ids = dict()
+                try:
+                    carrier = asset.global_properties["carriers"][asset.in_ports[0].carrier.id]
+                    id_number = carrier["id_number_mapping"]
+                    port = f"{carrier['type'].capitalize()}In"
+                    ids[port] = dict(carrier_id=id_number)
+                    carrier = asset.global_properties["carriers"][asset.out_ports[0].carrier.id]
+                    id_number = carrier["id_number_mapping"]
+                    port = f"{carrier['type'].capitalize()}Out"
+                    ids[port] = dict(carrier_id=id_number)
+                except:
+                    try:
+                        carrier = asset.global_properties["carriers"][asset.in_ports[0].carrier.id]
+                        id_number = carrier["id_number_mapping"]
+                        port = f"{carrier['type'].capitalize()}In"
+                        ids[port] = dict(carrier_id=id_number)
+                    except:
+                        carrier = asset.global_properties["carriers"][asset.out_ports[0].carrier.id]
+                        id_number = carrier["id_number_mapping"]
+                        port = f"{carrier['type'].capitalize()}Out"
+                        ids[port] = dict(carrier_id=id_number)
+                return ids


Add option for three ports (e.g. A/W HP with electric connection)

FJanssen-TNO · 2024-04-24T11:30:24Z

src/mesido/esdl/esdl_heat_model.py

+        else:
+            ids = dict()
+            for k in range(0, n):
+                try:
+                    carrier = asset.global_properties["carriers"][asset.in_ports[0].carrier.id]
+                    id_number = carrier["id_number_mapping"]
+                    port = f"{carrier['type'].capitalize()}Conn[{k+1}]"
+                    ids[port] = dict(carrier_id=id_number)
+                except:
+                    pass
+                try:
+                    carrier = asset.global_properties["carriers"][asset.out_ports[0].carrier.id]
+                    id_number = carrier["id_number_mapping"]
+                    port = f"{carrier['type'].capitalize()}Conn[{k+1}]"
+                    ids[port] = dict(carrier_id=id_number)
+                except:
+                    pass
+            return ids


remove as node carrier ids are set differently

FJanssen-TNO · 2024-05-05T18:10:15Z

src/mesido/financial_mixin.py

+                # This is something extra I created. It is a nested list in the form of:
+                # [[asset1.HeatIn, asset2.HeatOut], [asset3.HeatIn, asset4.HeatOut], ...]
+                conn = self.get_connections()


Instead of this list, you could potentially create a dict:
{"asset1.HeatIn": "asset2.HeatOut",
"asset3.HeatIn": "asset4.HeatOut"], ...

and create asset_con_dict = {"asset1": ["asset2"], "asset3": ["asset4", "asset5"]}
which just states the asset and to which it conects, can be deducted from previous list/dict.

and a dict listing the asset ports for each asset:
asset_port_dict = {"asset1": [HeatIn, HeatOut], "asset2": ["HeatIn", "HeatOut"], "asset3": ["Primary.HeatIn", "Primary.HeatOut", "Secondary.HeatIn", "Secondary.HeatOut"], ....}

FJanssen-TNO · 2024-05-05T18:11:00Z

src/mesido/financial_mixin.py

+            for asset in assets:
+                # This is something extra I created. It is a nested list in the form of:
+                # [[asset1.HeatIn, asset2.HeatOut], [asset3.HeatIn, asset4.HeatOut], ...]
+                conn = self.get_connections()


This line could be before the assets loop

FJanssen-TNO · 2024-05-05T18:30:00Z

src/mesido/financial_mixin.py

+                for connection in conn:
+                    # Here we check if our asset is in the connection hence we find a connected asset
+                    if asset == connection[0].split(".")[0] or asset == connection[1].split(".")[0]:
+                        other_asset = (
+                            connection[0].split(".")[0]
+                            if asset == connection[1].split(".")[0]
+                            else connection[1].split(".")[0]
+                        )
+                        # This bit of code is used to go from for example:
+                        # HeatExchanger.Secondary.HeatIn -> Secondary.HeatIn
+                        temp = (
+                            connection[1].split(".")[1:]
+                            if asset == connection[1].split(".")[0]
+                            else connection[0].split(".")[1:]
+                        )
+                        port = temp[0]
+                        for x in temp[1:]:
+                            port = port + "." + x
+
+                        # Here we check that the connected asset is not also owned by the same entity.


this could be skipped and one could loop over the connected assets named other_asset from asset_con_dict[asset]

FJanssen-TNO · 2024-05-05T18:44:39Z

src/mesido/financial_mixin.py

+                        # to represent the cashflow associated with the energy exchanged between the two
+                        # organizations.
+                        if other_asset not in assets:
+                            var_name = f"{asset}__revenue_{port}"


possible ports could now be retrieved from: asset_port_dict[asset]
looping over these possible ports (poss_port), one can check which port relates to this connection:
if conn[f"{asset}.{poss_port}].split(".")[0] == other_asset

FJanssen-TNO · 2024-05-05T19:00:15Z

src/mesido/financial_mixin.py

+                            var_name = f"{asset}__revenue_{port}"
+                            nominal_power = None
+                            carrier_name = None
+                            for _id, attr in self.get_electricity_carriers().items():


Potentially to generalise for commodities:
we could create a map commodity_var_map = {"heat": "Heat", "gas": "Q", "electricity": "Power"}
we could loop over the commodities = ["heat", "gas", "electricity"]

then a nested loop for this line could be done like:
for id, attr in getattr(self, f"get{commodity}_carriers")().items():

with the Power, Q and Heat replaced by commodity_var_map[commodity].

This can also be done for the ccreation of the variables line 119 to 147

jimrojerTNO added 2 commits April 9, 2024 17:59

parsing the entities, additional logic and parsing for having the car…

34bca46

…rier at every port in the network and instantiating the required revenue and cost variables

starting with the revenue constraints, electrolyser example now runs

4d39884

jimrojerTNO requested review from FJanssen-TNO and KobusVanRooyen as code owners April 10, 2024 11:41

jimrojerTNO added 2 commits April 11, 2024 16:23

things seem to run as expected now and revenues are computed, however…

9631f6b

… we need to give it the correct sign

signs are now fixed, everything seems to be consistent now, we should…

c91d89e

… now add variables and constriants for computing the profit on owner level

jimrojerTNO added 2 commits April 18, 2024 16:33

comments in financial mixin

017e1c5

fixes for tests

f253ca7

FJanssen-TNO reviewed May 5, 2024

View reviewed changes

jimrojerTNO added 4 commits September 6, 2024 15:25

merge main back in

6bc1458

style fixes

792aa86

start with incorperating feedback Femke

4aebe92

getting back the get_owner function

4ef1b91

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Organizational Entities and financial flows between them#21

Organizational Entities and financial flows between them#21
jimrojerTNO wants to merge 10 commits intomainfrom
organizational-entities

jimrojerTNO commented Apr 10, 2024

Uh oh!

KobusVanRooyen commented Apr 16, 2024

Uh oh!

FJanssen-TNO left a comment

Uh oh!

FJanssen-TNO Apr 24, 2024

Uh oh!

FJanssen-TNO Apr 24, 2024

Uh oh!

FJanssen-TNO May 5, 2024

Uh oh!

FJanssen-TNO May 5, 2024

Uh oh!

FJanssen-TNO May 5, 2024

Uh oh!

FJanssen-TNO May 5, 2024

Uh oh!

FJanssen-TNO May 5, 2024

Uh oh!

FJanssen-TNO May 5, 2024

Uh oh!

FJanssen-TNO May 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

jimrojerTNO commented Apr 10, 2024

Uh oh!

KobusVanRooyen commented Apr 16, 2024

Uh oh!

FJanssen-TNO left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants