Integrated heat storage and e-conversion asset by FJanssen-TNO · Pull Request #396 · Multi-Energy-Systems-Optimization/mesido

FJanssen-TNO · 2026-01-05T08:26:15Z

Start on creating an integrated heat storage asset that can be charged using electricity.
Using a heatbuffer with an additional electricity port.

Check setup
Add the parsing of the new relevant efficiencies --> e.g. charging efficiency (conversion of e to heat)
Check that still efficiency of the buffer can be set, e.g. self discharge rate or something else.
Add test
Update changelog

…d using electricity

# Conflicts: # src/mesido/pycml/component_library/milp/__init__.py # src/mesido/pycml/component_library/milp/multicommodity/__init__.py

FJanssen-TNO · 2026-02-17T10:41:15Z

src/mesido/esdl/esdl_heat_model.py

+
+            # ToDo: Check if max_supply (and also elec_power_nominal)
+            #  can be defined via hfr_charge_max.
+            max_supply = hfr_charge_max


this max_supply is the maximum heatflow

FJanssen-TNO · 2026-02-17T10:42:45Z

src/mesido/esdl/esdl_heat_model.py

+            for port in asset.in_ports:
+                if isinstance(port.carrier, esdl.ElectricityCommodity):
+                    min_voltage = port.carrier.voltage
+            i_max, i_nom = self._get_connected_i_nominal_and_max(asset)


This part can be generalized in a function. It is used at least at two other locations.

self._get_min_voltage(asset) function is created

FJanssen-TNO · 2026-02-17T10:46:17Z

src/mesido/esdl/esdl_heat_model.py

-        return HeatBuffer, modifiers
+            modifiers.update(
+                dict(
+                    id_mapping_carrier=id_mapping,


Why do we need an id_mapping_carrier? I don't see a use for it.

that is true actually. There is no need for this

FJanssen-TNO · 2026-02-17T11:59:05Z

src/mesido/esdl/esdl_heat_model.py

+                dict(
+                    **self._generic_heat_modifiers(-hfr_discharge_max, hfr_charge_max, q_nominal),
+                )
+            )


try to generalize this and the above __generic_heat_modifiers. The original implementation is okay.
In case "q_nominal" is a dict instead of a float due to the asset having more ports, you could also set q_nominal to q_nominal["Q_nominal"]

good idea. suggestion is implemented

FJanssen-TNO · 2026-02-17T12:01:18Z

src/mesido/pycml/component_library/milp/heat/heat_buffer.py


 @add_variables_documentation_automatically
-class HeatBuffer(_StorageComponent):
+class HeatBufferModel(_StorageComponent):


If this class is not supposed to be used directly, rather name it something like "_HeatBufferComponent" --> the underscore informs us that this model should not be used directly in MESIDO but only as an inherited model. Rather use "Component" instead of "Model" everything is a model...

fair point!
Done!

FJanssen-TNO · 2026-02-17T14:29:18Z

tests/test_heat.py

+        # Check heat flows into buffer coems from heat network and
+        # the electricity component of the buffer


Don't need long explanations for every check, only if it is not self explanatory, then ensure that is concise but clear, like "checking energy flows in and out of buffer".

FJanssen-TNO · 2026-02-17T14:30:25Z

tests/test_heat.py

+        np.testing.assert_allclose(
+            results["HeatStorage.Heat_buffer"],
+            results["HeatStorage.Heat_flow"] + results["HeatStorage.Heat_elec_charging"],
+        )


might be good to add additional check that actually derivative of stored heat is coming from heat loss and heat_buffer. This to ensure that really heat_buffer is used to calculate stored heat and not by accident heat_flow.

Check that derivative of stored heat is coming from heat loss and heat_buffer is added now

FJanssen-TNO · 2026-02-19T09:30:21Z

src/mesido/pycml/component_library/milp/multicommodity/heat_buffer_elec.py

+    The heat buffer component models heat storage in a tank. This component also incorporates the
+    ability to use electricity for charging this component. Like all heat storage components,
+    it loses heat to the surroundings, however here also an efficiency for the conversion of
+    electricity to heat is incorporated. Since this way of charging heat does not require water
+    flow through the inlet/outlet pipes, a separate variable is created to define the additional
+    heat charged.


In the description only explain what has been added in this asset.
So the ability to charge heat using electricity.

Docstring is updated

FJanssen-TNO · 2026-02-19T12:36:54Z

tests/models/simple_buffer/model/sourcesink_with_heater_ebuffer.esdl

This ESDL is more complicated than needed. Instead of a e-boiler, just the use of a generic heat producer should be okay.
Furthermore, the location of this esdl file is confusing, since in this folder I would only expect esdls with sources and sinks but no storage assets.

e-boiler is replaced by generic heater.

esdl and csv files are moved into "tests/models/simple_buffer"

FJanssen-TNO · 2026-02-19T12:42:12Z

tests/test_heat.py


 class TestHeat(TestCase):
+
+    def test_elec_heat_buffer_elec(self):


Seems unlogical to place this test overhere.

test is moved into "test_multiple_in_and_out_port_components"

start on creating an integrated heat storage asset that can be charge…

afb6a90

…d using electricity

FJanssen-TNO assigned tolga-akan Jan 6, 2026

tolga-akan added 11 commits January 28, 2026 15:28

Merge remote-tracking branch 'origin/main' into heat_storage_e_input

885ed3b

this commit is problematic. there is error to be resolved

15b6b01

Merge branch 'main' into heat_storage_e_input

6261a1f

Still we cannot test the functionally of e-buffer

3472997

olde input files are removed

e1655ec

Merge branch 'main' into heat_storage_e_input

12ab5d7

# Conflicts: # src/mesido/pycml/component_library/milp/__init__.py # src/mesido/pycml/component_library/milp/multicommodity/__init__.py

esdl is committed and main is merged

0b299bd

Merge branch 'main' into heat_storage_e_input

609d494

Merge branch 'main' into heat_storage_e_input

5a77f6e

not complete. heat buffer elec still requires some work

244f51b

completed

b580d99

tolga-akan marked this pull request as ready for review February 6, 2026 14:38

tolga-akan requested review from KobusVanRooyen and jimrojerTNO as code owners February 6, 2026 14:38

changelog is added

a41bb7f

FJanssen-TNO commented Feb 19, 2026

View reviewed changes

tolga-akan added 4 commits February 19, 2026 15:19

not complete

93f6622

not complete

8fc3dc8

PR review completed

b1462e5

esdl is added

2fe3a64

		# Check heat flows into buffer coems from heat network and
		# the electricity component of the buffer


		class TestHeat(TestCase):

		def test_elec_heat_buffer_elec(self):

Comments

Conversation

FJanssen-TNO commented Jan 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants