Upper limit of pipe specification in esdl#429
Draft
KobusVanRooyen wants to merge 3 commits into418-asset-max-size-and-esdl-attribute-usedfrom
Draft
Upper limit of pipe specification in esdl#429KobusVanRooyen wants to merge 3 commits into418-asset-max-size-and-esdl-attribute-usedfrom
KobusVanRooyen wants to merge 3 commits into418-asset-max-size-and-esdl-attribute-usedfrom
Conversation
src/mesido/esdl/esdl_mixin.py
Outdated
Comment on lines
290
to
291
| self._ESDLMixin__energy_system_handler.energy_system.esdlVersion is not None | ||
| and self._ESDLMixin__energy_system_handler.energy_system.esdlVersion > "v2507"# "v2401" # "v2507" # Currently latest esdlVersion="v2507" |
Collaborator
There was a problem hiding this comment.
extract the version number before the if statement, than if statement can be compact on one line.
src/mesido/esdl/esdl_mixin.py
Outdated
| min_size_idx = min_size_idx[0] | ||
|
|
||
| max_size = asset.attributes["diameter"].name | ||
| # Backward compatibility: |
Collaborator
There was a problem hiding this comment.
I would plug this whole part that was added in a small function, to keep it a bit more clean
…ax-size-and-esdl-attribute-used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.